Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at

Bug 174494

Summary: Review Request: libopensync-plugin-irmc
Product: [Fedora] Fedora Reporter: Andreas Bierfert <andreas.bierfert>
Component: Package ReviewAssignee: John Mahowald <jpmahowald>
Status: CLOSED NEXTRELEASE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-extras-list
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-02-05 01:07:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 174486    
Bug Blocks: 163779    

Description Andreas Bierfert 2005-11-29 15:41:29 UTC
Spec Name or Url:
SRPM Name or Url:
Irmc plugin for libopensync

Comment 1 John Mahowald 2006-01-29 16:51:55 UTC
Seems to be missing BuildRequires: openobex-devel

Comment 3 John Mahowald 2006-02-04 06:38:05 UTC
- rpmlint checks return:

rpmlint of libopensync-plugin-irmc-0.18-2.i386.rpm:E: libopensync-plugin-irmc
zero-length /usr/share/doc/libopensync-plugin-irmc-0.18/ChangeLog
E: libopensync-plugin-irmc zero-length
E: libopensync-plugin-irmc zero-length
E: libopensync-plugin-irmc zero-length

Empty doc files go.

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Ax the empty files and this is APPROVED.

Comment 5 John Mahowald 2006-02-04 14:39:19 UTC
Better. Release 3 APPROVED.

Comment 6 Andreas Bierfert 2006-02-05 01:07:04 UTC
Thanks. Imported and pushed.