Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 174494 - Review Request: libopensync-plugin-irmc
Summary: Review Request: libopensync-plugin-irmc
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: John Mahowald
QA Contact: David Lawrence
URL: http://www.opensync.org/
Whiteboard:
Depends On: 174486
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-11-29 15:41 UTC by Andreas Bierfert
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-02-05 01:07:04 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Andreas Bierfert 2005-11-29 15:41:29 UTC 
Spec Name or Url: http://fedora.lowlatency.de/review/libopensync-plugin-irmc.spec
SRPM Name or Url:
http://fedora.lowlatency.de/review/libopensync-plugin-irmc-0.18-1.src.rpm
Description:
Irmc plugin for libopensync
Comment 1 John Mahowald 2006-01-29 16:51:55 UTC 
Seems to be missing BuildRequires: openobex-devel
Comment 2 Andreas Bierfert 2006-01-29 21:43:09 UTC 
Fixed :)
http://fedora.lowlatency.de/review/libopensync-plugin-irmc-0.18-2.src.rpm
http://fedora.lowlatency.de/review/libopensync-plugin-irmc.spec
Comment 3 John Mahowald 2006-02-04 06:38:05 UTC 
- rpmlint checks return:

rpmlint of libopensync-plugin-irmc-0.18-2.i386.rpm:E: libopensync-plugin-irmc
zero-length /usr/share/doc/libopensync-plugin-irmc-0.18/ChangeLog
E: libopensync-plugin-irmc zero-length
/usr/share/doc/libopensync-plugin-irmc-0.18/AUTHORS
E: libopensync-plugin-irmc zero-length
/usr/share/doc/libopensync-plugin-irmc-0.18/README
E: libopensync-plugin-irmc zero-length
/usr/share/doc/libopensync-plugin-irmc-0.18/NEWS

Empty doc files go.

Good:
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Ax the empty files and this is APPROVED.
Comment 4 Andreas Bierfert 2006-02-04 09:28:40 UTC 
Thanks fixed in this one :)

http://fedora.lowlatency.de/review/libopensync-plugin-irmc-0.18-3.src.rpm
http://fedora.lowlatency.de/review/libopensync-plugin-irmc.spec
Comment 5 John Mahowald 2006-02-04 14:39:19 UTC 
Better. Release 3 APPROVED.
Comment 6 Andreas Bierfert 2006-02-05 01:07:04 UTC 
Thanks. Imported and pushed.
Note You need to log in before you can comment on or make changes to this bug.