Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 175278
Summary: | Review Request: gift-gnutella: Gnutella plugin for giFT | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
Component: | Package Review | Assignee: | Aurelien Bompard <gauret> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | gauret:
fedora-review+
wtogami: fedora-cvs+ |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-03-13 02:37:59 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 175276 | ||
Bug Blocks: |
Description
Rex Dieter
2005-12-08 14:52:38 UTC
Just one small problem: "Requires: gift" is redundant, the package already depends on libgift.so.0 (you should remove it in case you split the library out of the main package one day) * Mon Dec 19 2005 Rex Dieter <rexdieter[AT]users.sf.net. 0.11.8.1-2 - drop redundant Requires: gift Spec Name or Url:http://apt.kde-redhat.org/apt/kde-redhat/SPECS/gift-gnutella-0.0.10-2.spec SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/gift-gnutella-0.0.10-2.src.rpm At the end of %configure : use libxml..............: no libxml can be enabled with: +BuildRequires: libxml2-devel -%configure +%configure --with-libxml %changelog * Tue Dec 20 2005 Rex Dieter <rexdieter[AT]users.sf.net> 0.11.8.1-3 - --with-libxml, BR: libxml2-devel Spec Name or Url:http://apt.kde-redhat.org/apt/kde-redhat/SPECS/gift-gnutella-0.0.10-3.spec SRPM Name or Url: http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/gift-gnutella-0.0.10-3.src.rpm Packaging looks OK, but the Gnutella plugin can't connect here. It stays in status "Connecting..." in Apollon. The file data/gwebcaches in the tarball is probably missing. It could be useful to add data/hostiles.txt too. I've looked at some of the urls in data/gwebcaches, and it's only statistics, nothing illegal. > The file data/gwebcaches in the tarball is probably missing. It could be useful > to add data/hostiles.txt too. Take this from gtk-gnutella (already in Extras). > I've looked at some of the urls in data/gwebcaches, and it's only statistics, > nothing illegal. Sure! Upstream say the same. IMHO it is unusable to ship package without gwebcaches etc., therefore such data should be present in the package (and properly tested :)) I'll look into it. These seem like a upstream bugs to me, 'make install' should install all the bits needed for proper function. Just checked and gwebcaches, hostiles.txt already do get installed to /usr/share/giFT/Gnutella/ Is there something more that should/needs-to be done (packaging-wise)? Spec Name or Url:http://kde-redhat.unl.edu/apt/kde-redhat/SPECS/gift-gnutella.spec SRPM Name or Url: http://kde-redhat.unl.edu/apt/kde-redhat/all/SRPMS.stable/gift-gnutella-0.0.11-1.src.rpm %changelog * Thu Sep 14 2006 Rex Dieter <rexdieter[AT]users.sf.net> 0.0.11-1 - 0.0.11 Review for release 1.fc6: * RPM name is OK * Source gift-gnutella-0.0.11.tar.bz2 is the same as upstream * Builds fine in mock * rpmlint looks OK * File list looks OK * Works fine (30 checks have been run) APPROVED New Package CVS Request ======================= Package Name: gift-gnutella Short Description: Gnutella plugin for giFT Owners: rdieter.edu Branches: FC-5 FC-6 devel InitialCC: imported, builds queued, thanks. |