Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 175278 - Review Request: gift-gnutella: Gnutella plugin for giFT
Summary: Review Request: gift-gnutella: Gnutella plugin for giFT
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Aurelien Bompard
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: 175276
Blocks:
TreeView+ depends on / blocked
 
Reported: 2005-12-08 14:52 UTC by Rex Dieter
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-03-13 02:37:59 UTC
Type: ---
Embargoed:
gauret: fedora-review+
wtogami: fedora-cvs+

Attachments (Terms of Use)

Description Rex Dieter 2005-12-08 14:52:38 UTC 
Spec Name or
Url:http://apt.kde-redhat.org/apt/kde-redhat/SPECS/gift-gnutella-0.0.10-1.spec
SRPM Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/gift-gnutella-0.0.10-1.src.rpm
Description: Gnutella plugin for giFT.
Comment 1 Aurelien Bompard 2005-12-17 17:26:49 UTC 
Just one small problem:
"Requires: gift" is redundant, the package already depends on libgift.so.0 (you
should remove it in case you split the library out of the main package one day)
Comment 2 Rex Dieter 2005-12-19 12:47:22 UTC 
* Mon Dec 19 2005 Rex Dieter <rexdieter[AT]users.sf.net. 0.11.8.1-2
- drop redundant Requires: gift

Spec Name or
Url:http://apt.kde-redhat.org/apt/kde-redhat/SPECS/gift-gnutella-0.0.10-2.spec
SRPM Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/gift-gnutella-0.0.10-2.src.rpm
Comment 3 Aurelien Bompard 2005-12-20 11:00:38 UTC 
At the end of %configure :
use libxml..............: no

libxml can be enabled with:
+BuildRequires: libxml2-devel
-%configure
+%configure --with-libxml
Comment 4 Rex Dieter 2005-12-20 12:44:01 UTC 
%changelog
* Tue Dec 20 2005 Rex Dieter <rexdieter[AT]users.sf.net> 0.11.8.1-3
- --with-libxml, BR: libxml2-devel

Spec Name or
Url:http://apt.kde-redhat.org/apt/kde-redhat/SPECS/gift-gnutella-0.0.10-3.spec
SRPM Name or Url:
http://apt.kde-redhat.org/apt/kde-redhat/all/SRPMS.stable/gift-gnutella-0.0.10-3.src.rpm
Comment 5 Aurelien Bompard 2005-12-20 16:51:41 UTC 
Packaging looks OK, but the Gnutella plugin can't connect here. It stays in
status "Connecting..." in Apollon.
The file data/gwebcaches in the tarball is probably missing. It could be useful
to add data/hostiles.txt too.
I've looked at some of the urls in data/gwebcaches, and it's only statistics,
nothing illegal.
Comment 6 Dmitry Butskoy 2005-12-20 16:59:13 UTC 
> The file data/gwebcaches in the tarball is probably missing. It could be useful
> to add data/hostiles.txt too.
Take this from gtk-gnutella (already in Extras).

> I've looked at some of the urls in data/gwebcaches, and it's only statistics,
> nothing illegal.
Sure! Upstream say the same.

IMHO it is unusable to ship package without gwebcaches etc., therefore such data
should be present in the package (and properly tested :))
Comment 7 Rex Dieter 2005-12-20 17:02:32 UTC 
I'll look into it.

These seem like a upstream bugs to me, 'make install' should install all the
bits needed for proper function.
Comment 8 Rex Dieter 2005-12-20 17:56:03 UTC 
Just checked and gwebcaches, hostiles.txt already do get installed to
/usr/share/giFT/Gnutella/

Is there something more that should/needs-to be done (packaging-wise)?
Comment 9 Rex Dieter 2006-10-31 13:51:29 UTC 
Spec Name or
Url:http://kde-redhat.unl.edu/apt/kde-redhat/SPECS/gift-gnutella.spec
SRPM Name or Url:
http://kde-redhat.unl.edu/apt/kde-redhat/all/SRPMS.stable/gift-gnutella-0.0.11-1.src.rpm

%changelog
* Thu Sep 14 2006 Rex Dieter <rexdieter[AT]users.sf.net> 0.0.11-1
- 0.0.11
Comment 10 Aurelien Bompard 2007-03-10 09:45:29 UTC 
Review for release 1.fc6:
* RPM name is OK
* Source gift-gnutella-0.0.11.tar.bz2 is the same as upstream
* Builds fine in mock
* rpmlint looks OK
* File list looks OK
* Works fine
(30 checks have been run)

APPROVED
Comment 11 Rex Dieter 2007-03-12 17:22:16 UTC 
New Package CVS Request
=======================
Package Name: gift-gnutella
Short Description: Gnutella plugin for giFT
Owners: rdieter.edu
Branches: FC-5 FC-6 devel 
InitialCC:
Comment 12 Rex Dieter 2007-03-13 02:37:59 UTC 
imported, builds queued, thanks.
Note You need to log in before you can comment on or make changes to this bug.