Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 177038
| Summary: | Review Request: perl-version: Perl extension for Version Objects | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> |
| Component: | Package Review | Assignee: | Ralf Corsepius <rc040203> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-extras-list |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-03-01 14:42:39 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Tom "spot" Callaway
2006-01-05 17:24:55 UTC
NEEDSWORK: 1. Missing BuildRequires: perl(Module::Build) >= 0.2611 2. shipping *.bs 3. Redundant CFLAGS Fixed in -2: SRPM: http://www.auroralinux.org/people/spot/review/perl-version-0.50-2.src.rpm SPEC: http://www.auroralinux.org/people/spot/review/perl-version.spec By the way, version 0.51 is out (trivial update). Diff from version-0.50 to version-0.51 http://search.cpan.org/diff?from=version-0.50&to=version-0.51 Another suggestion: Tag the pod file listed in %files section as documentation. Bump to 0.51, tag the pod file as doc: SRPM: http://www.auroralinux.org/people/spot/review/perl-version-0.51-1.src.rpm SPEC: http://www.auroralinux.org/people/spot/review/perl-version.spec rpmlint isn't happy: # rpmlint perl-version-0.51-1.i386.rpm E: perl-version wrong-script-interpreter /usr/lib/perl5/vendor_perl/5.8.6/i386-linux-thread-multi/version.pm "perl"E: perl-version non-executable-script /usr/lib/perl5/vendor_perl/5.8.6/i386-linux-thread-multi/version.pm 0644 E: perl-version wrong-script-interpreter /usr/lib/perl5/vendor_perl/5.8.6/i386-linux-thread-multi/version/vxs.pm "perl" E: perl-version non-executable-script /usr/lib/perl5/vendor_perl/5.8.6/i386-linux-thread-multi/version/vxs.pm 0644 rpmlint complaints resolved in -2: SRPM: http://www.auroralinux.org/people/spot/review/perl-version-0.51-2.src.rpm SPEC: http://www.auroralinux.org/people/spot/review/perl-version.spec Some remarks on this excerpt from the spec:
sed -i "s|#!perl|#!%{_bindir}/perl|g" lib/version.pm
sed -i "s|#!perl|#!%{_bindir}/perl|g" lib/version/vxs.pm
1. You'd better use %{__perl} instead of %{_bindir}/perl in the sed pattern above.
2. These 2 lines could be written as one:
sed -i ... lib/version.pm lib/version/vxs.pm
3. The "global modifier" (.../g) in the sed pattern isn't necessary.
I'll approve the package when point 1 has been addressed.
-3 addresses all three points: SRPM: http://www.auroralinux.org/people/spot/review/perl-version-0.51-3.src.rpm SPEC: http://www.auroralinux.org/people/spot/review/perl-version.spec APPROVED Tom, I have just placed new build requests as the previous ones - 2764, 2765, 2766 - had failed (the required Module::Build version wasn't available at the time). jpo PS - This module could also be updated to version 0.53 Diff from version-0.51 to version-0.53 http://search.cpan.org/diff?from=version-0.51&to=version-0.53 Closing, apparently Spot missed to close this PR |