Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 177636
Summary: | Review Request: rtorrent | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Chabot <chabotc> |
Component: | Package Review | Assignee: | Hans de Goede <hdegoede> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-01-16 09:24:45 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 177635 | ||
Bug Blocks: | 163779 |
Description
Chris Chabot
2006-01-12 16:07:10 UTC
test build on x86_64 rawhide succeeded and spec looks good to me. Things which need to be changed: -Summary must not start with "A ..." remove "A .." -.so Requires are picked up by rpm automaticly, remove explicit requires -rtorrent.rc.example should be installed with 644 not 664 Possible improvements: -I would change "A client frontend to libtorrent" to "BitTorrent client using libtorrent" Formal Review: MUST review items: - Builds cleanly on FC5 devel. - rpmlint has no output / complaints - Source included matches upsteam source (md5sum) - Package name meets guidelines - spec file name is in %{name}.spec format - Licence (GPL) is fedora extra's compatible & is included in spec - Spec file is in (american) english - Does not list buildrequires that are excepted in the package guidelines - All build dependencies are listed - Proper use of ldconfig - All files have proper permissions - Package is not relocatable - No duplicate files in %files section - No missing files in %files section - Has a proper %clean section with rm -rf $RPM_BUILD_ROOT - Uses macro's described in PackagingGuidelines - No entries in %doc that are required for standard program operation - No -devel package needed - No directory-ownerships needed Should items: - Includes upstream licence file (COPYING) - No insane scriplets, or scriplets at all - No unnescesarry requires Looks good to me, changing blockerbug to FE-ACCEPT assuming that you will fix all items listed under "Things which need to be changed". * Sat Jan 14 2006 - Chris Chabot <chabotc> - 0.4.2-2 - Improved summary & description - Removed explicit requires, leaving to rpm - Changed mode of rtorrent.rc.example to 644 New urls: SPEC: http://www.xs4all.nl/~chabotc/rtorrent.spec SRPM: http://www.xs4all.nl/~chabotc/rtorrent-0.4.2-2.src.rpm Thanks! Really changing to FE-ACCEPT (forgot that last time). Approved, but please look over the description again the sentences aren't fluid. Thanks! Changed the description around a littlebit to make it a bit more fluid, that will teach me to use the description from the upstream homepage :-) Build cleanly for FC5 extra's. other brances pending CVSSync. Closing bug with NEXTRELEASE. |