Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 178604
Summary: | Review Request: ruby-mysql | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Oliver Andrich <oliver.andrich> |
Component: | Package Review | Assignee: | Mike McGrath <imlinux> |
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-extras-list |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-02-04 22:41:22 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Oliver Andrich
2006-01-22 11:53:46 UTC
Couple of things -Duplicate build requires: openssl-devel is provided by mysql-devel zlib-devel is provided by openssl-devel -Should clean the build root in %install (add rm -rf $RPM_BUILD_ROOT) Fixed these things. Spec Name or Url: http://roughbook.de/fedora/ruby-mysql.spec SRPM Name or Url: http://roughbook.de/fedora/ruby-mysql-2.7-3.src.rpm -Fix the changelog (you'll have to make a 2.7-4) -I'd package this in the Development/Languages group (php-mysql is) -use "make %{?_smp_mflags}" under %build rpmlint output: W: ruby-mysql incoherent-version-in-changelog 2.7-1 2.7-3 non-blocker: I think removing the summary from %description might clean it up a bit. Fixed the above mentioned things. Spec Name or Url: http://roughbook.de/fedora/ruby-mysql.spec SRPM Name or Url: http://roughbook.de/fedora/ruby-mysql-2.7-4.src.rpm One small thing. I'd release this under the GPL license. In the copying file it says the following: Ruby is copyrighted free software by Yukihiro Matsumoto <matz>. You can redistribute it and/or modify it under either the terms of the GPL (see the file GPL), or the conditions below. I'd just change the License to GPL since more people are familiar with it. Spec Name or Url: http://roughbook.de/fedora/ruby-mysql.spec SRPM Name or Url: http://roughbook.de/fedora/ruby-mysql-2.7-5.src.rpm As just discussed in #fedora-extras I switched to GPL as the licence, cause this is what the Packaging Guidelines tell in case of dual licensed software. I also included the license files. Found something else, this package creates /usr/lib/site_ruby/1.8/i386-linux/mysql.so Because it doesn't own those directories it leaves /usr/lib/site_ruby/1.8/i386-linux/ when you remove the package. Also aren't most ruby libraries located in /usr/lib/ruby/? Yes, this intended behaviour, cause /usr/lib/site_ruby/1.8/i386-linux/ is owned by the ruby-libs package. This package is required anyway, cause my package requires libruby.so.1.8 which is provided by the package ruby-libs. So I think, I don'T need to explicitly require ruby-libs. Got'cha. No problem there then: -rpmlint: No output -Meets Naming Guidelines -%{name}.spec matches -License is GPL and a COPYING file is included stating that fact -SPEC is written in english -SPEC file is easy to follow -Source matches Upstream -Compiles successfully in Mock -Only required build requres listed -No duplicate build requires -locales unused (not needed) -included libraries are not located in dynamic linker's default paths -No duplicate files -Owns all directories it creates: doesn't actually create any dirs -does not have any devel packages (does not need them) ACCEPTED |