Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 179710

Summary:	Review Request: dap-netcdf_handler - NetCDF 3 data handler for the OPeNDAP Data server
Product:	[Fedora] Fedora	Reporter:	Patrice Dumas <pertusus>
Component:	Package Review	Assignee:	Ed Hill <ed>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-02-20 12:41:23 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 179707

Description Patrice Dumas 2006-02-02 10:04:38 UTC

SRPM Name or Url: http://www.environnement.ens.fr/perso/dumas/fc-srpms/netcdf_handler-3.5.2-1.src.rpm
Description:

This is the netcdf data handler for our data server. It reads netcdf 3
files and returns DAP responses that are compatible with DAP2 and the
dap-server 3.5 software.

Comment 1 Patrice Dumas 2006-02-02 10:08:43 UTC

This bug depends on #179707, but circular dependencies are not allowed.

Comment 2 Ed Hill 2006-02-16 03:42:02 UTC

Hi Patrice, I took a quick look at this package and noticed two blockers:

 - License is LGPL not GPL
 - The package naming does not follow the packaging guidelines in two
   ways:
     1) the "_" delimiter is not permitted
     2) this is an addon package so its name should be 
        "dap-server-netcdf-handler" or similar

Comment 3 Patrice Dumas 2006-02-16 08:18:07 UTC

There is an exception when there is a _ in the upstream name:

"packages where the upstream name naturally contains an underscore are excluded
from this."

But I agree that there should be dap somewhere in the name. After some thinking,
I  am not convinced anymore that the handlers should depend on dap-server.
Although it is unlikely, they could be used as stand alone apps, so I propose
removing dependency on dap-server and calling the handler

dap-netcdf_handler

and so on, to retain the upstream _ but have a more informative name. Would this
suit you?

Comment 4 Ed Hill 2006-02-19 16:35:11 UTC

Hi Patrice, yes the "dap-netcdf_handler" name is fine so please go ahead 
and post an updated SRPM and I'll continue with the review.

Comment 5 Patrice Dumas 2006-02-20 00:00:33 UTC

Here is the updated srpm:
http://www.environnement.ens.fr/perso/dumas/fc-srpms/dap-netcdf_handler-3.5.2-1.src.rpm

Comment 6 Ed Hill 2006-02-20 01:48:10 UTC

Looks good, I don't see any blockers:

8d4d9ff2cca772f840b3b5449addeefc  dap-netcdf_handler-3.5.2-1.src.rpm

good:
 + source matches upstream
 + builds in mock on FC4
 + rpmlint reports no warnings or errors
 + spec is simple and easily read
 + dir ownership is good
 + license is good, and correctly included
 + no shared libs

APPROVED.

Comment 7 Christian Iseli 2006-10-18 13:16:50 UTC

Normalize summary field for easy parsing