Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 182941
Summary: | Review Request: nessus-core Network vulnerability scanner | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Andreas Bierfert <andreas.bierfert> |
Component: | Package Review | Assignee: | John Mahowald <jpmahowald> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | gajownik, imlinux |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-04-08 08:05:38 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 182743, 182744 | ||
Bug Blocks: | 163779 |
Description
Andreas Bierfert
2006-02-24 17:09:43 UTC
-Please provide a full URL to any sources/patches that have an upstream (Source0 is a must) -Inconsistant use of buildroot ($RPM_BUILD_ROOT, %buildroot %{buildroot}) pick one -Consolidate sbindir entries in nessus-server (non-blocker) Are you planning on packaging libICE? nessus-core requires it and its not in FC nor FE at this time. libICE is part of xorg and part of Fedora Core (this spec is for rawhide and thus BR libICE-devel only because of modular X) For the rest: http://fedora.lowlatency.de/review/nessus-core.spec http://fedora.lowlatency.de/review/nessus-core-2.2.6-2.src.rpm -changelog version number is wrapped on next line, put it on the same line as the date Mike, that is not a MUST. Andreas' full name and e-mail is so long, he prefers wrapping the line to reduce its width. Even with the version and name its still less than 80 characters long, I'll move that to should. If thats the only thinks holing this (besides the blocking bugs) I may change it :) Thanks for the explanation Michael I'm interested in getting this in extras but access to my rawhide box is limited as of late. One thing you could do if you wanted to get this in both FC4 and FC5 is to change your buildrequires: libice-devel to whatever header file(s) is/are required like: buildRequires: /usr/include/X11/ICE/ICElib.h If it was just your intention to have this available for FC-5 only then don't worry about it. I'll probably be reviewing this more closely soon. Well on FC4 you can just change all the xorg requires to xorg-x11-devel and this is what I would do once nessus as been imported to cvs ... :) Do you need me to spin an extras srpm for your reviewing or can you just change these? In the %description of nessus-core the 75,000 user number is duplicated. Delete one. Upon login the server says Cannot create a new dumpfile /var/log/nessus/nessusd.dump (No such file or directory)-- aborting This directory needs to exist and be owned by the server. Becuase the tarball includes the license, nessus/COPYING, include that in %doc For some reason every scan I've tried so far comes up empty. Hm did you setup up the plugin directory correctly? Did you install the plugins? Here is a version with the stuff you mentioned fixed. http://fedora.lowlatency.de/review/nessus-core-2.2.6-3.src.rpm http://fedora.lowlatency.de/review/nessus-core.spec (In reply to comment #11) > Hm did you setup up the plugin directory correctly? Did you install the plugins? > > Here is a version with the stuff you mentioned fixed. > > http://fedora.lowlatency.de/review/nessus-core-2.2.6-3.src.rpm > http://fedora.lowlatency.de/review/nessus-core.spec Exactly, upon adding plugin package (bug 185799) the scan works. Lots of rpmlint. We can ignore every changelog version due to line wrapping, and no docs because the docs are in other packages. rpmlint of nessus-gui-2.2.6-2.x86_64.rpm:W: nessus-gui no-version-in-last-changelog W: nessus-gui no-documentation rpmlint of nessus-server-2.2.6-2.x86_64.rpm:W: nessus-server summary-not-capitalized nessusd is the server part of the nessus client-server model W: nessus-server no-version-in-last-changelog E: nessus-server non-readable /etc/pki/nessus/private/CA/serverkey.pem 0600 E: nessus-server non-readable /etc/pki/nessus/private/CA/cakey.pem 0600 E: nessus-server incoherent-logrotate-file /etc/logrotate.d/nessusd E: nessus-server non-readable /etc/nessus/nessusd.conf 0600 W: nessus-server incoherent-init-script-name nessusd Permissions to be expected on keys. init script works, can ignore that. rpmlint of nessus-client-2.2.6-2.x86_64.rpm:W: nessus-client no-version-in-last-changelog W: nessus-client no-documentation rpmlint of nessus-core-2.2.6-2.x86_64.rpm:W: nessus-core no-version-in-last-changelog rpmlint of nessus-core-devel-2.2.6-2.x86_64.rpm:W: nessus-core-devel no-version-in-last-changelog rpmlint of nessus-gui-2.2.6-2.x86_64.rpm:W: nessus-gui no-version-in-last-changelog W: nessus-gui no-documentation rpmlint of nessus-server-2.2.6-2.x86_64.rpm:W: nessus-server summary-not-capitalized nessusd is the server part of the nessus client-server model W: nessus-server no-version-in-last-changelog E: nessus-server non-readable /etc/pki/nessus/private/CA/serverkey.pem 0600 E: nessus-server non-readable /etc/pki/nessus/private/CA/cakey.pem 0600 E: nessus-server incoherent-logrotate-file /etc/logrotate.d/nessusd E: nessus-server non-readable /etc/nessus/nessusd.conf 0600 W: nessus-server incoherent-init-script-name nessusd logrotate conf looks fine to me. rpmlint of nessus-client-2.2.6-2.x86_64.rpm:W: nessus-client no-version-in-last-changelog W: nessus-client no-documentation rpmlint of nessus-core-2.2.6-2.x86_64.rpm:W: nessus-core no-version-in-last-changelog rpmlint of nessus-core-devel-2.2.6-2.x86_64.rpm:W: nessus-core-devel no-version-in-last-changelog rpmlint of nessus-gui-2.2.6-3.x86_64.rpm:W: nessus-gui no-version-in-last-changelog W: nessus-gui no-documentation rpmlint of nessus-server-2.2.6-3.x86_64.rpm:W: nessus-server summary-not-capitalized nessusd is the server part of the nessus client-server model W: nessus-server no-version-in-last-changelog E: nessus-server non-readable /etc/pki/nessus/private/CA/cakey.pem 0600 E: nessus-server non-readable /etc/nessus/nessusd.conf 0600 E: nessus-server incoherent-logrotate-file /etc/logrotate.d/nessusd E: nessus-server non-readable /etc/pki/nessus/private/CA/serverkey.pem 0600 W: nessus-server incoherent-init-script-name nessusd rpmlint of nessus-client-2.2.6-3.x86_64.rpm:W: nessus-client no-version-in-last-changelog W: nessus-client no-documentation rpmlint of nessus-core-2.2.6-3.x86_64.rpm:W: nessus-core no-version-in-last-changelog rpmlint of nessus-core-devel-2.2.6-3.x86_64.rpm:W: nessus-core-devel no-version-in-last-changelog - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file for gui - devel package ok (with just includes no need to depend on main package libraries) APPROVED Thanks for the review. Build and pushed :) |