Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1836408
| Summary: | [PATCH] mate 1.24 workspace switcher popup needs better color contrast | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | William Bader <williambader> | ||||||||||
| Component: | marco | Assignee: | Wolfgang Ulbrich <fedora> | ||||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||
| Severity: | unspecified | Docs Contact: | |||||||||||
| Priority: | unspecified | ||||||||||||
| Version: | 31 | CC: | fedora, stefano, williambader | ||||||||||
| Target Milestone: | --- | ||||||||||||
| Target Release: | --- | ||||||||||||
| Hardware: | x86_64 | ||||||||||||
| OS: | Linux | ||||||||||||
| Whiteboard: | |||||||||||||
| Fixed In Version: | marco-1.24.0-2.fc31 | Doc Type: | If docs needed, set a value | ||||||||||
| Doc Text: | Story Points: | --- | |||||||||||
| Clone Of: | Environment: | ||||||||||||
| Last Closed: | 2020-06-11 18:58:52 UTC | Type: | Bug | ||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||
| Documentation: | --- | CRM: | |||||||||||
| Verified Versions: | Category: | --- | |||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||
| Embargoed: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
William Bader
2020-05-15 20:03:29 UTC
I am not guilty, workspace-switcher is re-designed by MATE upstream to use a OSD style with compositor. You need to enable the compositor in marco. This looks much better. https://github.com/mate-desktop/marco/pull/566 If you like changes you need to file out a report at upstream. Thanks! I enabled it with the path below, and it looks much better. Menu -> System Preferences -> Windows -> Window Preferences -> [x] Enable software compositing window manager Created attachment 1692056 [details]
patch that fixes the problem
When compositing is enabled, the background of the workspace switcher popup is dark, so the selected workspace was changed to be a light color.
However, without compositing, the background is light, so this change made the selected workspace hard to see.
The attached patch restores showing the selected workspace with a dark color when compositing is disabled.
Created attachment 1692057 [details]
screen captures showing the changes
The image is a grid of screen captures showing that the change makes the selected workspace easier to see when compositing is disabled and leaves the colors the same as before when compositing is enabled.
Created attachment 1692062 [details]
updated screen captures showing the difference
Your patch fixes the problem, i like to test it a bit more. Thanks. Thanks for testing it. I submitted a pull request https://github.com/mate-desktop/marco/pull/623 FEDORA-2020-a656802d0e has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-a656802d0e FEDORA-2020-a656802d0e has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-a656802d0e` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-a656802d0e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. marco-1.24.0-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. |