Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1836408 - [PATCH] mate 1.24 workspace switcher popup needs better color contrast
Summary: [PATCH] mate 1.24 workspace switcher popup needs better color contrast
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: marco
Version: 31
Hardware: x86_64
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Wolfgang Ulbrich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-05-15 20:03 UTC by William Bader
Modified: 2020-06-11 18:58 UTC (History)
3 users (show)

Fixed In Version: marco-1.24.0-2.fc31
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-06-11 18:58:52 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
screen capture of mate 1.24 task switcher (2.84 KB, image/png)
2020-05-15 20:03 UTC, William Bader 		no flags Details
patch that fixes the problem (970 bytes, patch)
2020-05-25 20:36 UTC, William Bader 		no flags Details | Diff
screen captures showing the changes (113.85 KB, image/png)
2020-05-25 20:39 UTC, William Bader 		no flags Details
updated screen captures showing the difference (113.12 KB, image/png)
2020-05-25 21:06 UTC, William Bader 		no flags Details
Show Obsolete (1) View All

Description William Bader 2020-05-15 20:03:29 UTC 
Created attachment 1689070 [details]
screen capture of mate 1.24 task switcher

Description of problem:

The workspace switcher needs a stronger color contrast to make the current workspace more visible. The current workspace is light cyan, while empty workspaces are light gray.

Is there any way to configure it?
I tried right-clicking on the workspace switcher in the panel, but it just sets the dimensions.
I also tried looking at desktop color themes.
Can the colors be configured in files like xfce? https://forum.xfce.org/viewtopic.php?id=13485

Version-Release number of selected component (if applicable):

It happened when Fedora 31 updated from Mate 1.22 to 1.24.

How reproducible:

All the time. I have a custom desktop theme similar to 'TraditionalOk' that has passed through several Fedora in-place upgrades.
I have a grid with 5 workspaces across and 4 workspaces down.
About half of the workspaces have a full size xterm.

Steps to Reproduce:
1. Press any of the keys to switch workspaces and look at the popup.
2.
3.

Actual results:

The current workspace is light cyan which is hard to see against empty workspaces with light gray and xterm workspaces that have a dark black border.

Expected results:

A stronger color like dark blue for the current workspace.
Or just finding a way to restore what Mate 1.22 did.

Additional info:
Comment 1 Wolfgang Ulbrich 2020-05-16 08:50:03 UTC 
I am not guilty, workspace-switcher is re-designed by MATE upstream to use a OSD style with compositor.
You need to enable the compositor in marco. This looks much better.
https://github.com/mate-desktop/marco/pull/566
If you like changes you need to file out a report at upstream.
Comment 2 William Bader 2020-05-16 17:04:25 UTC 
Thanks! I enabled it with the path below, and it looks much better.
Menu -> System Preferences -> Windows -> Window Preferences -> [x] Enable software compositing window manager
Comment 3 William Bader 2020-05-25 20:36:59 UTC 
Created attachment 1692056 [details]
patch that fixes the problem

When compositing is enabled, the background of the workspace switcher popup is dark, so the selected workspace was changed to be a light color.
However, without compositing, the background is light, so this change made the selected workspace hard to see.
The attached patch restores showing the selected workspace with a dark color when compositing is disabled.
Comment 4 William Bader 2020-05-25 20:39:26 UTC 
Created attachment 1692057 [details]
screen captures showing the changes

The image is a grid of screen captures showing that the change makes the selected workspace easier to see when compositing is disabled and leaves the colors the same as before when compositing is enabled.
Comment 5 William Bader 2020-05-25 21:06:47 UTC 
Created attachment 1692062 [details]
updated screen captures showing the difference
Comment 6 Wolfgang Ulbrich 2020-05-26 19:30:09 UTC 
Your patch fixes the problem, i like to test it a bit more.
Thanks.
Comment 7 William Bader 2020-05-26 20:26:20 UTC 
Thanks for testing it. I submitted a pull request https://github.com/mate-desktop/marco/pull/623
Comment 8 Fedora Update System 2020-06-01 08:36:49 UTC 
FEDORA-2020-a656802d0e has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-a656802d0e
Comment 9 Fedora Update System 2020-06-02 04:00:36 UTC 
FEDORA-2020-a656802d0e has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-a656802d0e`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-a656802d0e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 10 Fedora Update System 2020-06-11 18:58:52 UTC 
marco-1.24.0-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.