Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1845562
Summary: | system-upgrade plugin should do "dnf group upgrade" as part of transaction solution | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Neal Gompa <ngompa13> |
Component: | dnf-plugins-extras | Assignee: | Pavla Kratochvilova <pkratoch> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | low | ||
Version: | 33 | CC: | bugzilla, carl, dmach, fedoraproject, igor.raits, jkadlcik, jmracek, klember, mblaha, mcatanza, mhroncok, nsella, pkratoch, rpm-software-management, tpopela, vmukhame |
Target Milestone: | --- | Keywords: | Triaged |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | dnf-plugins-extras-4.0.12-1.fc32 dnf-plugins-extras-4.0.12-1.fc33 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-10-18 15:49:15 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Neal Gompa
2020-06-09 14:11:39 UTC
Essentially to get installed groups you need: installed_groups = [g.ui_name for g in self.base.comps.groups if self.base.history.group.get(g.id)] Then to actually run upgrade of them: self.base.env_group_upgrade(installed_groups) However, the problem is that when Workstation is installed, no groups are in the history, so DNF does not know about any installed group. Bummer. It actually does record... Some of them.. ❯ sudo dnf group list --installed Last metadata expiration check: 1:02:48 ago on Tue 09 Jun 2020 03:48:30 PM CEST. Installed Groups: Container Management LibreOffice GNOME Desktop Environment Fonts Hardware Support But I installed Fedora Workstation from Live just yesterday. there's also the thing where it hides most of the groups by default unless you pass some magic flags... 1. the user installs a group 2. the user removes a package that is part of the group from (1) 3. the user system upgrades Which of the following do you propose to happen? 4a. the package removed in (2) is brought back 4b. the package removed in (2) is not brought back (unless required by something else) 4b The goal is to ensure users get new packages by default, not to second-guess users who remove things. Thanks for clarifying. Thank you very much for the report and for the discussion. I see that expected behaviour is not to bring back removed packages and we have to also careful with the default behaviour. Suggestions about why the package is not on the system will only provides inconsistent behaviour between systems, therefore I suggest to create a new option that will update also groups or modules. This bug appears to have been reported against 'rawhide' during the Fedora 33 development cycle. Changing version to 33. Here is a PR that adds upgrading of groups and environments into system-upgrade: https://github.com/rpm-software-management/dnf-plugins-extras/pull/183 It still needs to be tested, but the group upgrade should not install back packages that were explicitly removed or excluded during the groups installation. *** Bug 1814306 has been marked as a duplicate of this bug. *** FEDORA-2020-b40fc174b5 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-b40fc174b5 FEDORA-2020-5d9f0ce2b3 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-5d9f0ce2b3 FEDORA-2020-b40fc174b5 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-b40fc174b5` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-b40fc174b5 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-b40fc174b5 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-b40fc174b5 FEDORA-2020-5d9f0ce2b3 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-5d9f0ce2b3 FEDORA-2020-b40fc174b5 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-b40fc174b5` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-b40fc174b5 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-5d9f0ce2b3 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-5d9f0ce2b3` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-5d9f0ce2b3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-5d9f0ce2b3 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2020-b40fc174b5 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-b40fc174b5 FEDORA-2020-b40fc174b5 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-b40fc174b5` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-b40fc174b5 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-b40fc174b5 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. |