Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 185212
Summary: | Review Request: freedoom - open source doom game files | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Wart <wart> |
Component: | Package Review | Assignee: | Hans de Goede <hdegoede> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-03-14 20:38:06 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 185211 | ||
Bug Blocks: | 163779 |
Description
Wart
2006-03-11 20:48:48 UTC
Adding Hans to cc: per his request. Changes to the game data files directory, per the discussion in BZ #185211 (prboom) http://www.kobold.org/~wart/fedora/freedoom-0.4.1-2.src.rpm http://www.kobold.org/~wart/fedora/freedoom.spec MUST ==== * Source tarball matches upstream * Package (and .spec) named properly * License file included * Spec file readable, in Am. English * Builds on FC-5 x86_64 * No locale files * No excessive BR: or Requires: * Not relocatable * buildroot cleaned up in %install and %clean * No duplicate files * permissions ok * Macro usage consistent * Contains permissable content * Desktop file included and properly installed MUST FIX ======== License must be BSD not Distributable SHOULD FIX ========== * Use %{version} in Source0 * Remove: # This package should Provide <enginename>-data for each doom engine # that it is known to work with. Concedering the procedure for doom wads we agreed on this is no longer true. One more try to address all must and should fix issues: http://www.kobold.org/~wart/fedora/freedoom-0.4.1-3.src.rpm http://www.kobold.org/~wart/fedora/freedoom.spec Looks good, APPROVED. Imported and built. Thanks! |