Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1860668
Summary: | Review Request: golang-gopkg-jdkato-prose-1 - A Golang library for text processing | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Athos Ribeiro <athoscribeiro> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | package-review, quantum.analyst, zebob.m |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-08-21 20:06:15 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1851355, 1863862 |
Description
Athos Ribeiro
2020-07-26 12:51:39 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=47869918 Note that we already have golang-github-jdkato-prose packaged, which now ships prose version 2. Prose v2 dropped the transform package, which is needed by Hugo. This is backwards though. The import path for v2.0.0, according to go.mod, is github.com/jdkato/prose/v2. That translates to a package name of golang-github-jdkato-prose-2, so _it_ is the one that should have the new package request. Does it mean I should not have updated prose to v2? (https://src.fedoraproject.org/rpms/golang-github-jdkato-prose/c/b8cb1fee3f9763e4b43dcc247e0c458e0e2a1969?branch=master) Sorry for the confusion, should have pinged you guys before bumping the major release. Not really sure what the way forward here is. Do we have a section on the golang packaging guidelines for this? Should I downgrade golang-github-jdkato-prose (bumping the epoch?) and package a new golang-github-jdkato-prose-2 package? (In reply to Athos Ribeiro from comment #4) > Does it mean I should not have updated prose to v2? > (https://src.fedoraproject.org/rpms/golang-github-jdkato-prose/c/ > b8cb1fee3f9763e4b43dcc247e0c458e0e2a1969?branch=master) > > Sorry for the confusion, should have pinged you guys before bumping the > major release. > > Not really sure what the way forward here is. Do we have a section on the > golang packaging guidelines for this? > > Should I downgrade golang-github-jdkato-prose (bumping the epoch?) and > package a new golang-github-jdkato-prose-2 package? I've made the same mistake, bumping the Epoch is the way to go, reverting the change. Then you can do a separate package with: %global goipath github.com/jdkato/prose/v2 (don't use go2rpm with /v2, add it after the spec creation because otherwise, go2rpm can't fetch the Github license and description) You can still add gopkg.in/jdkato/prose.v1 as an alternative ipath to the v1 package. It is not mentioned as the default import path in the v1 though. Hi Robert, Sorry for the long delay here :) I bumped the epoch and referenced this bug in the changelog for further reference (I also added it to my personal notes so I won't make the same mistake in the future). I will not open a new bug for v2, since I do not need it for now. Thanks for the review and guidance |