Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1860668 - Review Request: golang-gopkg-jdkato-prose-1 - A Golang library for text processing
Summary: Review Request: golang-gopkg-jdkato-prose-1 - A Golang library for text proce...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1851355 1863862
TreeView+ depends on / blocked
 
Reported: 2020-07-26 12:51 UTC by Athos Ribeiro
Modified: 2020-08-21 20:06 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-08-21 20:06:15 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Athos Ribeiro 2020-07-26 12:51:39 UTC 
Spec URL: https://athoscr.fedorapeople.org//golang-gopkg-jdkato-prose-1.spec
SRPM URL: https://athoscr.fedorapeople.org//golang-gopkg-jdkato-prose-1-1.2.0-1.fc32.src.rpm

Description:

A Golang library for text processing, including tokenization, part-of-speech
tagging, and named-entity extraction.
Comment 1 Athos Ribeiro 2020-07-26 12:51:43 UTC 
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=47869918
Comment 2 Athos Ribeiro 2020-07-26 12:53:58 UTC 
Note that we already have golang-github-jdkato-prose packaged, which now ships prose version 2. Prose v2 dropped the transform package, which is needed by Hugo.
Comment 3 Elliott Sales de Andrade 2020-08-03 19:55:50 UTC 
This is backwards though. The import path for v2.0.0, according to go.mod, is github.com/jdkato/prose/v2. That translates to a package name of golang-github-jdkato-prose-2, so _it_ is the one that should have the new package request.
Comment 4 Athos Ribeiro 2020-08-07 21:32:46 UTC 
Does it mean I should not have updated prose to v2? (https://src.fedoraproject.org/rpms/golang-github-jdkato-prose/c/b8cb1fee3f9763e4b43dcc247e0c458e0e2a1969?branch=master)

Sorry for the confusion, should have pinged you guys before bumping the major release.
 
Not really sure what the way forward here is. Do we have a section on the golang packaging guidelines for this?

Should I downgrade golang-github-jdkato-prose (bumping the epoch?) and package a new golang-github-jdkato-prose-2 package?
Comment 5 Robert-André Mauchin 🐧 2020-08-09 04:36:20 UTC 
(In reply to Athos Ribeiro from comment #4)
> Does it mean I should not have updated prose to v2?
> (https://src.fedoraproject.org/rpms/golang-github-jdkato-prose/c/
> b8cb1fee3f9763e4b43dcc247e0c458e0e2a1969?branch=master)
> 
> Sorry for the confusion, should have pinged you guys before bumping the
> major release.
>  
> Not really sure what the way forward here is. Do we have a section on the
> golang packaging guidelines for this?
> 
> Should I downgrade golang-github-jdkato-prose (bumping the epoch?) and
> package a new golang-github-jdkato-prose-2 package?

I've made the same mistake, bumping the Epoch is the way to go, reverting the change.
Then you can do a separate package with:  

%global goipath         github.com/jdkato/prose/v2

(don't use go2rpm with /v2, add it after the spec creation because otherwise, go2rpm can't fetch the Github license and description)
Comment 6 Robert-André Mauchin 🐧 2020-08-09 04:40:56 UTC 
You can still add gopkg.in/jdkato/prose.v1 as an alternative ipath to the v1 package. It is not mentioned as the default import path in the v1 though.
Comment 7 Athos Ribeiro 2020-08-21 20:06:15 UTC 
Hi Robert,

Sorry for the long delay here :)

I bumped the epoch and referenced this bug in the changelog for further reference (I also added it to my personal notes so I won't make the same mistake in the future).

I will not open a new bug for v2, since I do not need it for now.

Thanks for the review and guidance
Note You need to log in before you can comment on or make changes to this bug.