Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 186264
Summary: | Review Request: bcm43xx-fwcutter | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | David Woodhouse <dwmw2> |
Component: | Package Review | Assignee: | Ville Skyttä <scop> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-04-03 20:40:06 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
David Woodhouse
2006-03-22 16:45:20 UTC
/usr/bin => %{_bindir} - $RPM_OPT_FLAGS not honored, fixed eg. by this in %prep: sed -i -e 's/-O2/$(RPM_OPT_FLAGS)/' Makefile - man page not installed - unusual Group tag, suggesting "System Environment/Base" or another suitable one from /usr/share/doc/rpm-*/GROUPS - bogus version in changelog entry - last sentence in README.Fedora ends a bit abruptly, should it have included some info about where to report success or failure? Thanks for the feedback. Updated spec file and RPM at the same places. Yes, I meant to go create a bug in bugzilla and finish the last sentence in README.Fedora. Bug #186329. I also added /etc/modprobe.d/bcm43xx.conf to make automatic loading of the module work. IMO this package is a wrong place to have the modprobe.d snippet in. Once firmwares have been extracted, this package can be removed as it's no longer needed, and that resulting in blowing away the config snippet is very much unexpected. How about just dropping it and documenting bcm43xx related stuff for FC5 in the Wiki? Please bump the release number and add %chnagelog entries every time changes are made, even during package review. I've changed the modprobe.d snippet to just a %doc file, and referred to it in the README.Fedora file. OK? Yep, approved. I see this is already available in devel, but not in FC-5. The FC-5 branch exists in CVS though, so could you push a build for it and close this when done? By the way, 004 is out. I tried yesterday but the build failed due to infrastructure breakage. Will try again... Looks better now, thanks. Please add the package in owners.list |