186264 – Review Request: bcm43xx-fwcutter

Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.

Bug 186264 - Review Request: bcm43xx-fwcutter

Summary: Review Request: bcm43xx-fwcutter

Keywords:
Status:	CLOSED NEXTRELEASE
Alias:	None
Product:	Fedora
Classification:	Fedora
Component:	Package Review
Sub Component:
Version:	rawhide
Hardware:	All
OS:	Linux
Priority:	medium
Severity:	medium
Target Milestone:	---
Assignee:	Ville Skyttä
QA Contact:	Fedora Package Reviews List
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:	FE-ACCEPT
TreeView+	depends on / blocked

Reported:	2006-03-22 16:45 UTC by David Woodhouse
Modified:	2007-11-30 22:11 UTC (History)
CC List:	0 users
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:	2006-04-03 20:40:06 UTC
Type:	---
Embargoed:
Dependent Products:

Attachments	(Terms of Use)

Description David Woodhouse 2006-03-22 16:45:20 UTC

Spec Name or Url: http://david.woodhou.se/bcm43xx-fwcutter.spec
SRPM Name or Url: http://david.woodhou.se/bcm43xx-fwcutter-003-1.src.rpm
Description: This package contains the 'bcm43xx-fwcutter' tool which is used to
extract firmware for the Broadcom network devices, from the official
Windows, MacOS or Linux drivers.

See the README.Fedora file shipped in the package's documentation for
instructions on using this tool.

Comment 1 Frank Arnold 2006-03-22 18:39:13 UTC

/usr/bin => %{_bindir}

Comment 2 Ville Skyttä 2006-03-22 19:29:57 UTC

- $RPM_OPT_FLAGS not honored, fixed eg. by this in %prep:  
  sed -i -e 's/-O2/$(RPM_OPT_FLAGS)/' Makefile  
- man page not installed  
- unusual Group tag, suggesting "System Environment/Base" or another suitable 
  one from /usr/share/doc/rpm-*/GROUPS 
- bogus version in changelog entry  
- last sentence in README.Fedora ends a bit abruptly, should it have included 
  some info about where to report success or failure?

Comment 3 David Woodhouse 2006-03-22 22:45:27 UTC

Thanks for the feedback. Updated spec file and RPM at the same places. 

Yes, I meant to go create a bug in bugzilla and finish the last sentence in
README.Fedora. Bug #186329.

Comment 4 David Woodhouse 2006-03-23 00:32:44 UTC

I also added /etc/modprobe.d/bcm43xx.conf to make automatic loading of the
module work.

Comment 5 Ville Skyttä 2006-03-23 19:39:47 UTC

IMO this package is a wrong place to have the modprobe.d snippet in.  Once 
firmwares have been extracted, this package can be removed as it's no longer 
needed, and that resulting in blowing away the config snippet is very much 
unexpected.  How about just dropping it and documenting bcm43xx related stuff 
for FC5 in the Wiki? 
 
Please bump the release number and add %chnagelog entries every time changes 
are made, even during package review.

Comment 6 David Woodhouse 2006-03-23 22:56:56 UTC

I've changed the modprobe.d snippet to just a %doc file, and referred to it in
the README.Fedora file. OK?

Comment 7 Ville Skyttä 2006-03-24 07:28:24 UTC

Yep, approved.

Comment 8 Ville Skyttä 2006-03-30 21:36:00 UTC

I see this is already available in devel, but not in FC-5.  The FC-5 branch
exists   in CVS though, so could you push a build for it and close this when
done?  By the way, 004 is out.

Comment 9 David Woodhouse 2006-03-31 06:08:12 UTC

I tried yesterday but the build failed due to infrastructure breakage. Will try
again...

Comment 10 Ville Skyttä 2006-04-03 20:40:06 UTC

Looks better now, thanks.

Comment 11 Christian Iseli 2006-04-08 20:43:54 UTC

Please add the package in owners.list

Note You need to log in before you can comment on or make changes to this bug.