Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1869376
| Summary: | pkgconfig file uses /usr/local/ for variables. | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ankur Sinha (FranciscoD) <sanjay.ankur> |
| Component: | fish | Assignee: | Oliver Falk <ofalk> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | igor.raits, luto, ofalk, oliver |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | fish-3.1.2-5.fc33 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-09-25 16:37:46 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ankur Sinha (FranciscoD)
2020-08-17 18:23:39 UTC
Hi!
I've just pushed and built a new version to rawhide => fish-3.1.2-5.fc34
https://koji.fedoraproject.org/koji/taskinfo?taskID=50139697
Can you please check?
KR,
Oliver
Hi Oliver, I'm afraid I don't have a rawhide system, so I cannot install the package to check the package config file. Could you please use one of the test systems to check the package? https://fedoraproject.org/wiki/Test_Machine_Resources_For_Package_Maintainers (I *think* these are still usable, even with the data centre move ongoing). Cheers, Ankur Hi!
No need to check this explicitly on a Rawhide machine. A local rebuild my some other Fedora machine:
# for i in prefix datadir completionsdir functionsdir confdir; do echo -n "$i: "; pkg-config --variable $i fish; done
prefix: /usr
datadir: /usr/share
completionsdir: /usr/share/fish/vendor_completions.d
functionsdir: /usr/share/fish/vendor_functions.d
confdir: /usr/share/fish/vendor_conf.d
So, from my point of view, this is fixed. The question is if we should also move this fix to f32 and f31. I hope the primary maintainer can chime in on this.
Thanks, I don't use fish, but I *think* those variables look correct now. The primary issue was the use of `/usr/local`, which isn't used any more. I think it's worth pushing the update to F32 and F31 too, since other packages that use the fish package config variables otherwise need to workaround the bug separately in those branches. Igor, what do you think. F32 + F31 as well for that? If you don't have the bandwidth at the moment, let me know and I can handle it. Oliver Agreed with Igor, I'll take care about F31 + 32! Oliver Almost missed epel-8. :-\ Anyway. Fixed in: - Rawhide - F32 - F33 - EPEL-8 Builds are done or in progress. Therefore putting this on RELEASE_PENDING. EL8: https://koji.fedoraproject.org/koji/buildinfo?buildID=1602288 F31: https://koji.fedoraproject.org/koji/buildinfo?buildID=1602285 F32: https://koji.fedoraproject.org/koji/buildinfo?buildID=1602282 F33: https://koji.fedoraproject.org/koji/buildinfo?buildID=1602341 Rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1600803 FEDORA-2020-95b468e8a3 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-95b468e8a3 Positive karma appreciated: - https://bodhi.fedoraproject.org/updates/FEDORA-2020-3165619eda - https://bodhi.fedoraproject.org/updates/FEDORA-2020-dbf27f4f92 - https://bodhi.fedoraproject.org/updates/FEDORA-2020-95b468e8a3 - https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-6eb2d3837b FEDORA-2020-95b468e8a3 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-95b468e8a3` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-95b468e8a3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2020-95b468e8a3 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. |