Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1880721
Summary: | Review Request: hydroxide - A third-party, open-source ProtonMail bridge | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | proletarius101 |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED UPSTREAM | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | mail, package-review, zebob.m |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2023-01-17 02:56:00 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1881789, 1881793, 1881794, 1881796, 1881797, 1881798, 1881799, 1881800, 1881801, 1881802, 1881803, 1881804, 1881806, 1881808, 2124347 | ||
Bug Blocks: | 177841 |
Description
proletarius101
2020-09-19 11:52:57 UTC
You need to submit a review request for every package. And please use the template as a lot of reviewers are using fedora-review. All reviews should block hydroxide. > You need to submit a review request for every package.
Thanks for your instruction!
Those packages are submitted. Please take a look.
- I prefer: sed -i 's|golang.org/x/crypto|github.com/ProtonMail/crypto|' $(find . -name *.go) to match the rest of Go packages. - the spec file name must match the name of the spec: hydroxide.spec - Build fails: # github.com/emersion/hydroxide/protonmail _build/src/github.com/emersion/hydroxide/protonmail/contacts.go:167:66: too many arguments in call to openpgp.CheckArmoredDetachedSignature have (openpgp.KeyRing, *bytes.Buffer, io.Reader, nil) want (openpgp.KeyRing, io.Reader, io.Reader) _build/src/github.com/emersion/hydroxide/protonmail/contacts.go:193:55: too many arguments in call to openpgp.CheckArmoredDetachedSignature have (openpgp.KeyRing, *strings.Reader, *strings.Reader, nil) want (openpgp.KeyRing, io.Reader, io.Reader) _build/src/github.com/emersion/hydroxide/protonmail/crypto.go:39:21: subkey.PublicKey.KeyExpired undefined (type *packet.PublicKey has no field or method KeyExpired) _build/src/github.com/emersion/hydroxide/protonmail/crypto.go:56:137: i.SelfSignature.SigExpired undefined (type *packet.Signature has no field or method SigExpired) _build/src/github.com/emersion/hydroxide/protonmail/crypto.go:73:21: subkey.PublicKey.KeyExpired undefined (type *packet.PublicKey has no field or method KeyExpired) _build/src/github.com/emersion/hydroxide/protonmail/crypto.go:87:80: i.SelfSignature.SigExpired undefined (type *packet.Signature has no field or method SigExpired) _build/src/github.com/emersion/hydroxide/protonmail/srp.go:45:41: too many arguments in call to openpgp.CheckDetachedSignature have (openpgp.EntityList, *bytes.Reader, io.Reader, nil) want (openpgp.KeyRing, io.Reader, io.Reader) Seems the commit you packaged for ProtonMail/crypto https://github.com/ProtonMail/crypto/commit/5c72a883971a4325f8c62bf07b6d38c20ea47a6a has been yanked from any branch. Build is successful after building the latest git commit for ProtonMail/crypto - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Please fix the aforementioned issue. This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted. This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket. |