Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1880721 - Review Request: hydroxide - A third-party, open-source ProtonMail bridge
Summary: Review Request: hydroxide - A third-party, open-source ProtonMail bridge
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1881789 1881793 1881794 1881796 1881797 1881798 1881799 1881800 1881801 1881802 1881803 1881804 1881806 1881808
Blocks: FE-NEEDSPONSOR
TreeView+ depends on / blocked
 
Reported: 2020-09-19 11:52 UTC by proletarius101
Modified: 2020-11-04 17:47 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
zebob.m: fedora-review?

Attachments (Terms of Use)

Description proletarius101 2020-09-19 11:52:57 UTC 
Spec URL: https://download.copr.fedorainfracloud.org/results/proletarius101/hydroxide/fedora-33-x86_64/01677871-hydroxide/golang-github-emersion-hydroxide.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/proletarius101/hydroxide/fedora-33-x86_64/01677871-hydroxide/hydroxide-0.2.15-1.fc33.src.rpm
Description: 

Hydroxide is a third-party, open-source ProtonMail bridge. For power users only, designed to run on a server.

hydroxide supports CardDAV, IMAP and SMTP.

Fedora Account System Username: proletarius101

It's my first package so it would be nice to have someone as my sponsor. I'm a contributor of hydroxide and it's related packages. We hope to make it into Fedora: https://github.com/emersion/hydroxide/issues/118
Comment 1 Fabian Affolter 2020-09-22 18:39:55 UTC 
You need to submit a review request for every package. And please use the template as a lot of reviewers are using fedora-review.

All reviews should block hydroxide.
Comment 2 proletarius101 2020-09-23 06:23:53 UTC 
> You need to submit a review request for every package.

Thanks for your instruction! 

Those packages are submitted. Please take a look.
Comment 3 Robert-André Mauchin 🐧 2020-11-04 17:47:56 UTC 
 - I prefer:

sed -i 's|golang.org/x/crypto|github.com/ProtonMail/crypto|' $(find . -name *.go)

to match the rest of Go packages.

 - the spec file name must match the name of the spec: hydroxide.spec

 - Build fails:

# github.com/emersion/hydroxide/protonmail
_build/src/github.com/emersion/hydroxide/protonmail/contacts.go:167:66: too many arguments in call to openpgp.CheckArmoredDetachedSignature
	have (openpgp.KeyRing, *bytes.Buffer, io.Reader, nil)
	want (openpgp.KeyRing, io.Reader, io.Reader)
_build/src/github.com/emersion/hydroxide/protonmail/contacts.go:193:55: too many arguments in call to openpgp.CheckArmoredDetachedSignature
	have (openpgp.KeyRing, *strings.Reader, *strings.Reader, nil)
	want (openpgp.KeyRing, io.Reader, io.Reader)
_build/src/github.com/emersion/hydroxide/protonmail/crypto.go:39:21: subkey.PublicKey.KeyExpired undefined (type *packet.PublicKey has no field or method KeyExpired)
_build/src/github.com/emersion/hydroxide/protonmail/crypto.go:56:137: i.SelfSignature.SigExpired undefined (type *packet.Signature has no field or method SigExpired)
_build/src/github.com/emersion/hydroxide/protonmail/crypto.go:73:21: subkey.PublicKey.KeyExpired undefined (type *packet.PublicKey has no field or method KeyExpired)
_build/src/github.com/emersion/hydroxide/protonmail/crypto.go:87:80: i.SelfSignature.SigExpired undefined (type *packet.Signature has no field or method SigExpired)
_build/src/github.com/emersion/hydroxide/protonmail/srp.go:45:41: too many arguments in call to openpgp.CheckDetachedSignature
	have (openpgp.EntityList, *bytes.Reader, io.Reader, nil)
	want (openpgp.KeyRing, io.Reader, io.Reader)


Seems the commit you packaged for ProtonMail/crypto https://github.com/ProtonMail/crypto/commit/5c72a883971a4325f8c62bf07b6d38c20ea47a6a has been yanked from any branch.

Build is successful after building the latest git commit for ProtonMail/crypto


 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Please fix the aforementioned issue.
Note You need to log in before you can comment on or make changes to this bug.