Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 188376
Summary: | Review Request: perl-Test-Tester | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Steven Pritchard <steve> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-04-10 20:16:44 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 188378, 188380 | ||
Bug Blocks: | 163779 |
Description
Steven Pritchard
2006-04-08 19:19:20 UTC
It looks like the dependencies are backwards on this; it's a requirement for perl-Test-Deep, not the other way around. So I'll just review all of them. Builds fine in mock (development branch) and rpmlint is silent. Issues: The package says it's under the same license as perl, but then includes the file "ARTISTIC" and makes no mention of the GPL. Odd; upstream should be whacked, but not a blocker. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written, uses macros consistently and conforms to the Perl template. * license field matches the actual license. * license is open source-compatible and license text is included in the package. * source files match upstream: 31d58158d2a6cdb7ad9d9fe3e0aed86e Test-Tester-0.103.tar.gz 31d58158d2a6cdb7ad9d9fe3e0aed86e Test-Tester-0.103.tar.gz-srpm * package builds in mock. * BuildRequires are proper. * final provides and requires are sane. * no shared libraries are present. * package is not relocatable. * owns the directory it creates. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %test is present and all tests pass. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. * The package owns %{perl_vendorlib}/Test, which will probably also be owned by any module under the Test:: namespace. However, none of the dependencies create this directory so there is no alternative but for this package to own it. APPROVED Oops, sorry about the order of the dependencies. Imported into CVS and builds requested. |