Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 188376 - Review Request: perl-Test-Tester
Summary: Review Request: perl-Test-Tester
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
Depends On: 188378 188380
TreeView+ depends on / blocked
Reported: 2006-04-08 19:19 UTC by Steven Pritchard
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2006-04-10 20:16:44 UTC
Type: ---

Attachments (Terms of Use)

Description Steven Pritchard 2006-04-08 19:19:20 UTC
Spec Name or Url:
SRPM Name or Url:
If you have written a test module based on Test::Builder then Test::Tester
allows you to test it with the minimum of effort.

Comment 1 Jason Tibbitts 2006-04-09 17:53:30 UTC
It looks like the dependencies are backwards on this; it's a requirement for
perl-Test-Deep, not the other way around.  So I'll just review all of them.

Comment 2 Jason Tibbitts 2006-04-09 18:25:15 UTC
Builds fine in mock (development branch) and rpmlint is silent.

The package says it's under the same license as perl, but then includes the file
"ARTISTIC" and makes no mention of the GPL.  Odd; upstream should be whacked,
but not a blocker.

* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently and
conforms to the Perl template.
* license field matches the actual license.
* license is open source-compatible and license text is included in the package.
* source files match upstream:
   31d58158d2a6cdb7ad9d9fe3e0aed86e  Test-Tester-0.103.tar.gz
   31d58158d2a6cdb7ad9d9fe3e0aed86e  Test-Tester-0.103.tar.gz-srpm
* package builds in mock.
* BuildRequires are proper.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directory it creates.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %test is present and all tests pass.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
* The package owns %{perl_vendorlib}/Test, which will probably also be owned by
any module under the Test:: namespace.  However, none of the dependencies create
this directory so there is no alternative but for this package to own it.


Comment 3 Steven Pritchard 2006-04-10 20:16:44 UTC
Oops, sorry about the order of the dependencies.

Imported into CVS and builds requested.

Note You need to log in before you can comment on or make changes to this bug.