Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 188378
Summary: | Review Request: perl-Test-NoWarnings | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Steven Pritchard <steve> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-04-10 20:26:03 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 188380 | ||
Bug Blocks: | 163779, 188376 |
Description
Steven Pritchard
2006-04-08 19:30:07 UTC
Builds fine in mock (development branch, with dependencies added) and rpmlint is silent. Issues: For grammar's sake, s/modules/module/ in the description. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written, uses macros consistently and conforms to the Perl template. * license field matches the actual license. * license is open source-compatible. Text of license is included in the package. * source files match upstream: 702143eab77ffc335a08beccac47dca4 Test-NoWarnings-0.082.tar.gz 702143eab77ffc335a08beccac47dca4 Test-NoWarnings-0.082.tar.gz-srpm * package builds in mock. * BuildRequires are proper. * final provides and requires are sane. * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is present and all tests pass. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. * The package owns %{perl_vendorlib}/Test, which is also owned by other modules in the Test:: namespace. No dependency owns this directory, however, so there's no alternative. APPROVED. Typo fixed in CVS. Imported in CVS and builds requested. perl-Test-NoWarnings-0.083-1.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/perl-Test-NoWarnings-0.083-1.el4 perl-Test-NoWarnings-0.083-1.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report. |