Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 188623
| Summary: | Review Request: SOAPpy - Full-featured SOAP library for Python | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christopher Stone <tkmame> |
| Component: | Package Review | Assignee: | Wart <wart> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Flags: | kevin:
fedora-cvs+
|
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-04-18 12:31:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Christopher Stone
2006-04-11 20:01:58 UTC
MUST ==== * rpmlint output clean * Source matches upstream. md5sum: 51ac835366badedd932c64f26fa8336b SOAPpy-0.11.6.tar.gz * License (PSFL) ok, license file included * Package and spec file named appropriately * Spec file legible and in Am. English * Builds and packages in mock on FC-4 i386, FC-4 x86_64, devel i386, devel x86_64 * No locales * No shared libraries * Not relocatable * buildroot cleaned in at beginning of %install and in %clean * No duplicate files * Macro use consistent * Contains code, not content * No -devel package necessary * No .la archives * No .desktop file needed * Owns all directories that it creates. SHOULD ====== * There are some unit tests in the tests subdirectory. Consider running the test suite in the spec file to verify that the package works. * There are a lot of example scripts in contrib/, bid/, validate that could be included as example code in %doc. MUSTFIX ======= * Is BuildRequires: PyXML necessary? It seems to build fine without it. * The files in the docs subdirectory need to be added to %doc. Spec URL: http://tkmame.retrogames.com/fedora-extras/SOAPpy.spec SRPM URL: http://tkmame.retrogames.com/fedora-extras/ * Mon Apr 17 2006 Christopher Stone <chris.stone> 0.11.6-2 - Add docs directory to %doc - Remove PyXML BR - Removed executable bits from doc files - Added call to run test script in %check - Added a patch to remove tests that fail - Added examples to %doc There are two tests that fail. One of the tests is _supposed_ to fail. I had to add a patch to comment out the tests that fail to allow rpmbuild to make the rpm. The test that fails which is supposed to pass prints this: ====================================================================== ERROR: testTime (__main__.SOAPTestCase) ---------------------------------------------------------------------- Traceback (most recent call last): File "SOAPtest.py", line 2201, in testTime self.allTests(t, baddata, gooddata, parsedata) File "SOAPtest.py", line 1727, in allTests self.goodTest(t, gooddata) File "SOAPtest.py", line 1695, in goodTest d = x._marshalData() File "/home/build/SOAPpy-0.11.6/SOAPpy/Types.py", line 593, in _marshalData s = time.strftime("%H:%M:%S", (0, 0, 0) + d + (0, 0, -1)) ValueError: month out of range All MUST and SHOULD items have been addressed. APPROVED Package Change Request ====================== Package Name: SOAPpy New Branches: EL-5 cvs done. |