Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 188623 - Review Request: SOAPpy - Full-featured SOAP library for Python
Summary: Review Request: SOAPpy - Full-featured SOAP library for Python
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Wart
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-04-11 20:01 UTC by Christopher Stone
Modified: 2007-12-13 02:10 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-04-18 12:31:53 UTC
Type: ---
Embargoed:
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Christopher Stone 2006-04-11 20:01:58 UTC 
Spec URL: http://tkmame.retrogames.com/fedora-extras/SOAPpy.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/

Description: 
The goal of the SOAPpy team is to provide a full-featured SOAP library
for Python that is very simple to use and that fully supports dynamic
interaction between clients and servers.
Comment 1 Wart 2006-04-17 14:39:42 UTC 
MUST
====
* rpmlint output clean
* Source matches upstream.  md5sum:
  51ac835366badedd932c64f26fa8336b  SOAPpy-0.11.6.tar.gz
* License (PSFL) ok, license file included
* Package and spec file named appropriately
* Spec file legible and in Am. English
* Builds and packages in mock on FC-4 i386, FC-4 x86_64, devel i386, devel x86_64
* No locales
* No shared libraries
* Not relocatable
* buildroot cleaned in at beginning of %install and in %clean
* No duplicate files
* Macro use consistent
* Contains code, not content
* No -devel package necessary
* No .la archives
* No .desktop file needed
* Owns all directories that it creates.

SHOULD
======
* There are some unit tests in the tests subdirectory.  Consider running
  the test suite in the spec file to verify that the package works.

* There are a lot of example scripts in contrib/, bid/, validate that could
  be included as example code in %doc.

MUSTFIX
=======
* Is BuildRequires: PyXML necessary?  It seems to build fine without it.
* The files in the docs subdirectory need to be added to %doc.
Comment 2 Christopher Stone 2006-04-17 20:38:18 UTC 
Spec URL: http://tkmame.retrogames.com/fedora-extras/SOAPpy.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/

* Mon Apr 17 2006 Christopher Stone <chris.stone> 0.11.6-2
- Add docs directory to %doc
- Remove PyXML BR
- Removed executable bits from doc files
- Added call to run test script in %check
- Added a patch to remove tests that fail
- Added examples to %doc

There are two tests that fail.  One of the tests is _supposed_ to fail.  I had
to add a patch to comment out the tests that fail to allow rpmbuild to make the rpm.

The test that fails which is supposed to pass prints this:
======================================================================
ERROR: testTime (__main__.SOAPTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "SOAPtest.py", line 2201, in testTime
    self.allTests(t, baddata, gooddata, parsedata)
  File "SOAPtest.py", line 1727, in allTests
    self.goodTest(t, gooddata)
  File "SOAPtest.py", line 1695, in goodTest
    d = x._marshalData()
  File "/home/build/SOAPpy-0.11.6/SOAPpy/Types.py", line 593, in _marshalData
    s = time.strftime("%H:%M:%S", (0, 0, 0) + d + (0, 0, -1))
ValueError: month out of range
Comment 3 Wart 2006-04-18 01:23:51 UTC 
All MUST and SHOULD items have been addressed.

APPROVED
Comment 4 Christopher Stone 2007-12-12 23:02:12 UTC 
Package Change Request
======================
Package Name: SOAPpy
New Branches: EL-5
Comment 5 Kevin Fenzi 2007-12-13 02:10:04 UTC 
cvs done.
Note You need to log in before you can comment on or make changes to this bug.