Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 189093
Summary: | Review Request: mono-debugger | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Paul F. Johnson <paul> | ||||||||
Component: | Package Review | Assignee: | John Mahowald <jpmahowald> | ||||||||
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||||||
Severity: | medium | Docs Contact: | |||||||||
Priority: | medium | ||||||||||
Version: | rawhide | CC: | dwmw2, lyz27 | ||||||||
Target Milestone: | --- | ||||||||||
Target Release: | --- | ||||||||||
Hardware: | All | ||||||||||
OS: | Linux | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | Environment: | ||||||||||
Last Closed: | 2006-09-02 14:23:01 UTC | Type: | --- | ||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Bug Depends On: | |||||||||||
Bug Blocks: | 163779, 179260 | ||||||||||
Attachments: |
|
Description
Paul F. Johnson
2006-04-16 00:24:40 UTC
Spec URL: http://www.smmp.salford.ac.uk/packages/mono-debugger.spec SRPM URL: http://www.smmp.salford.ac.uk/packages/mono-debugger-0.12-2.src.rpm libdir set to /usr/lib irrespective of hardware built on spec file minor tweaks Not building in mock. Should move Requires: glib2 to BuildRequires: glib2-devel checking for glib-2.0 >= 2.0.0... Package glib-2.0 was not found in the pkg-config search path. Perhaps you should add the directory containing `glib-2.0.pc' to the PKG_CONFIG_PATH environment variable No package 'glib-2.0' found configure: error: Library requirements (glib-2.0 >= 2.0.0) not met; consider adjusting the PKG_CONFIG_PATH environment variable if your libraries are in a nonstandard prefix so pkg-config can find them. Spec URL: http://www.smmp.salford.ac.uk/packages/mono-debugger.spec SRPM URL: http://www.smmp.salford.ac.uk/packages/mono-debugger-0.12-3.src.rpm Change log Fix for glib2-devel (#2) Added devel package 64 bit architecture fix Spec file tweaks Added --disable-static to the configure line and removed the find line in the installer Spec URL: http://www.knox.net.nz/~nodoid/mono-debugger.spec SRPM URL: http://www.knox.net.nz/~nodoid/mono-debugger-0.12-3.src.rpm Change of URL Those globs in %files are playing evil with directories ownership. [iago@puhisher ~]$ rpm -qf /usr/lib/mono/1.0 mono-core-1.1.13.7-1.fc5.1 mono-debugger-0.12-3 [iago@puhisher ~]$ rpm -qf /usr/lib/mono/gac gtk-sharp2-2.8.2-1 gtk-sharp-1.0.10-5 mono-core-1.1.13.7-1.fc5.1 gtksourceview-sharp-2.0-7 monodoc-1.1.13-6 mono-debugger-0.12-3 Both /usr/lib/mono/1.0 and /usr/lib/mono/gac should be owned by mono-core. A quick fix up for mono-debugger.spec: %files %defattr(-, root, root) %doc AUTHORS COPYING ChangeLog README README.FreeBSD README.build TODO NEWS RELEASE-NOTES* %{_bindir}/mdb %{_libdir}/*.so* %{_libdir}/mono/1.0/*.exe %{_libdir}/mono/1.0/gac/Mono.Debugger/* %{_libdir}/mono/1.0/gac/Mono.Debugger.Cecil/* %{_libdir}/pkgconfig/mono-debugger.pc Spec URL: http://www.knox.net.nz/~nodoid/mono-debugger.spec SRPM URL: http://www.knox.net.nz/~nodoid/mono-debugger-0.12-4.src.rpm Addresses problems seen in #5 SRPM is 404 not found. Sorry. Should be up in the next couple of mins. Still missing glib2-devel in BuildRequires. Also missing mono-devel Missing a %clean section. Doesn't build on x86_64, pkgconfig is not finding mono. checking for mono >= 1.1.13 glib-2.0 >= 2.0.0 ... Package mono was not found in the pkg-config search path. Perhaps you should add the directory containing `mono.pc' to the PKG_CONFIG_PATH environment variable No package 'mono' found configure: error: Library requirements (mono >= 1.1.13 glib-2.0 >= 2.0.0 ) not met; consider adjusting the PKG_CONFIG_PATH environment variable if your libraries are in a nonstandard prefix so pkg-config can find them. mono-devel does provide /usr/lib64/pkgconfig/mono.pc on x86_64. The redefining _libdir part should go. Spec URL: http://www.knox.net.nz/~nodoid/mono-debugger.spec SRPM URL: http://www.knox.net.nz/~nodoid/mono-debugger-0.30-1.src.rpm Bump to new version Fixes the problems listed above. The mono hack is currently okay (grudgingly) I have a feeling that when this is approved, that monodevelop will be able to use it as well :-) mono-devel does provide /usr/lib64/pkgconfig/mono.pc on x86_64. No. mono-libs-devel provides the mono.pc file Ping! It looks like mono-debugger is going to be required for the next release of MonoDevelop (due shortly) so this package could probably do with being looked at Spec URL: http://www.knox.net.nz/~nodoid/mono-debugger.spec SRPM URL: http://www.knox.net.nz/~nodoid/mono-debugger-0.30-2.src.rpm Removes the old mono hack Rebuilt for new mono packages Added BR mono-nunit Added R pkgconfig for -devel Spec URL: http://www.knox.net.nz/~nodoid/mono-debugger.spec SRPM URL: http://www.knox.net.nz/~nodoid/mono-debugger-0.30-3.src.rpm Fixes correctly for 64 bit Additional BRs (autoconf and automake) Moved README.build to the -devel package Fixed ownership problem on a directory Better with the libdir fix, but still needs some work: - Missing a %defattr entry for devel package - Source0 is 404, looks like you want http://go-mono.com/sources/mono-debugger/mono-debugger-0.30.tar.gz - don't disable debug, there is debugging symbols. - license is not LGPL, looks like MIT Spec URL: http://www.knox.net.nz/~nodoid/mono-debugger.spec Fixes all from #15 - tar ball is the same Created attachment 135088 [details]
New spec file
Sorry had to put the new spec file here, but I can't seem to upload at the
moment
Created attachment 135090 [details]
monodebug-configure patch
Doesn't build, needs a BuildRequires: libtool to get past autoreconf. When it does build, I get: E: mono-debugger shlib-with-non-pic-code /usr/lib64/libmonodebuggerreadline.so.0.0.0 Not sure why, the build log indicates compiling with -fPIC Created attachment 135251 [details]
Fixed spec file
Fixes the libtool problem. I can't reproduce the fPIC problem (though I thought
that problem was no longer a blocker or something like that)
+ License (MIT) + source matches upstream + builds fine on x86_64, with libdir patch + devel package with pkgconfig file + name-version-release follows guidelines + proper use of macros + proper file permissions + *.la files removed + proper clean section APPROVED I've had to add excludearch-ppc to get it to build on the buildsys due to missing definitions in the ppc %{_includedir}/sys/user.h file Please do not remove the FE-ACCEPT blocker. Thanks. Is this package still excluded on PPC? If so, the bug on the FE-ExcludeArch-ppc tracker shouldn't be closed. Please could you open a new bug if the package still isn't working -- and then fix the bug too :) The bug is down to something missing in the PPC version of glibc (it's not been ported across if memory serves me right). I did file a BZ report on it but was told that the missing bit wasn't going to be implemented. What bugzilla number? If the "something missing" is something that mono-debugger can't do without, then it would be strange for the glibc bug to be closed 'wontfix'. If it's something that mono-debugger _can_ do without, then mono-debugger should be fixed. Either way, there should be a bug filed against mono-debugger which a) Clearly explains the problem b) depends on the glibc bug you mention c) blocks FE-ExcludeArch-ppc Aha, it seems to be bug 205017. |