Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 189093 - Review Request: mono-debugger
Summary: Review Request: mono-debugger
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: John Mahowald
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT F-ExcludeArch-ppc
TreeView+ depends on / blocked
 
Reported: 2006-04-16 00:24 UTC by Paul F. Johnson
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-09-02 14:23:01 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
New spec file (deleted)
2006-08-28 21:30 UTC, Paul F. Johnson
no flags Details
monodebug-configure patch (deleted)
2006-08-28 21:41 UTC, Paul F. Johnson
no flags Details | Diff
Fixed spec file (deleted)
2006-08-31 00:17 UTC, Paul F. Johnson
no flags Details

Description Paul F. Johnson 2006-04-16 00:24:40 UTC
Spec URL: http://www.smmp.salford.ac.uk/packages/mono-debugger.spec
SRPM URL: http://www.smmp.salford.ac.uk/packages/mono-debugger-0.12-1.src.rpm
Description: 

mono-debugger is a debugger for mono which can be executed from either the command line or as part of MonoDevelop

Comment 1 Paul F. Johnson 2006-04-18 22:14:49 UTC
Spec URL: http://www.smmp.salford.ac.uk/packages/mono-debugger.spec
SRPM URL: http://www.smmp.salford.ac.uk/packages/mono-debugger-0.12-2.src.rpm

libdir set to /usr/lib irrespective of hardware built on
spec file minor tweaks

Comment 2 John Mahowald 2006-04-22 21:11:46 UTC
Not building in mock. Should move Requires: glib2 to BuildRequires: glib2-devel

checking for glib-2.0 >= 2.0.0... Package glib-2.0 was not found in the
pkg-config search path. Perhaps you should add the directory containing
`glib-2.0.pc' to the PKG_CONFIG_PATH environment variable No package 'glib-2.0'
found
configure: error: Library requirements (glib-2.0 >= 2.0.0) not met; consider
adjusting the PKG_CONFIG_PATH environment variable if your libraries are in a
nonstandard prefix so pkg-config can find them.


Comment 3 Paul F. Johnson 2006-06-02 15:09:42 UTC
Spec URL: http://www.smmp.salford.ac.uk/packages/mono-debugger.spec
SRPM URL: http://www.smmp.salford.ac.uk/packages/mono-debugger-0.12-3.src.rpm

Change log

Fix for glib2-devel (#2)
Added devel package
64 bit architecture fix
Spec file tweaks
Added --disable-static to the configure line and removed the find line in the
installer


Comment 4 Paul F. Johnson 2006-06-04 13:34:39 UTC
Spec URL: http://www.knox.net.nz/~nodoid/mono-debugger.spec
SRPM URL: http://www.knox.net.nz/~nodoid/mono-debugger-0.12-3.src.rpm

Change of URL

Comment 5 Iago Rubio 2006-06-04 19:13:11 UTC
Those globs in %files are playing evil with directories ownership.

[iago@puhisher ~]$ rpm -qf /usr/lib/mono/1.0
mono-core-1.1.13.7-1.fc5.1
mono-debugger-0.12-3

[iago@puhisher ~]$ rpm -qf /usr/lib/mono/gac
gtk-sharp2-2.8.2-1
gtk-sharp-1.0.10-5
mono-core-1.1.13.7-1.fc5.1
gtksourceview-sharp-2.0-7
monodoc-1.1.13-6
mono-debugger-0.12-3

Both /usr/lib/mono/1.0 and /usr/lib/mono/gac should be owned by mono-core.

A quick fix up for mono-debugger.spec:

%files
%defattr(-, root, root)
%doc AUTHORS COPYING ChangeLog README README.FreeBSD README.build TODO NEWS
RELEASE-NOTES*
%{_bindir}/mdb
%{_libdir}/*.so*
%{_libdir}/mono/1.0/*.exe
%{_libdir}/mono/1.0/gac/Mono.Debugger/*
%{_libdir}/mono/1.0/gac/Mono.Debugger.Cecil/*
%{_libdir}/pkgconfig/mono-debugger.pc


Comment 6 Paul F. Johnson 2006-06-04 21:16:14 UTC
Spec URL: http://www.knox.net.nz/~nodoid/mono-debugger.spec
SRPM URL: http://www.knox.net.nz/~nodoid/mono-debugger-0.12-4.src.rpm

Addresses problems seen in #5


Comment 7 John Mahowald 2006-07-08 05:02:32 UTC
SRPM is 404 not found.

Comment 8 Paul F. Johnson 2006-08-10 11:17:33 UTC
Sorry. Should be up in the next couple of mins.

Comment 9 John Mahowald 2006-08-16 17:08:55 UTC
Still missing glib2-devel in BuildRequires. Also missing mono-devel

Missing a %clean section.

Doesn't build on x86_64, pkgconfig is not finding mono.

checking for mono >= 1.1.13 glib-2.0 >= 2.0.0 ... Package mono was not found in
the pkg-config search path. Perhaps you should add the directory containing
`mono.pc' to the PKG_CONFIG_PATH environment variable No package 'mono' found
configure: error: Library requirements (mono >= 1.1.13 glib-2.0 >= 2.0.0 ) not
met; consider adjusting the PKG_CONFIG_PATH environment variable if your
libraries are in a nonstandard prefix so pkg-config can find them.

mono-devel does provide /usr/lib64/pkgconfig/mono.pc on x86_64.

The redefining _libdir part should go.


Comment 10 Paul F. Johnson 2006-08-16 21:04:49 UTC
Spec URL: http://www.knox.net.nz/~nodoid/mono-debugger.spec
SRPM URL: http://www.knox.net.nz/~nodoid/mono-debugger-0.30-1.src.rpm

Bump to new version
Fixes the problems listed above. The mono hack is currently okay (grudgingly)

I have a feeling that when this is approved, that monodevelop will be able to
use it as well :-)

Comment 11 Paul F. Johnson 2006-08-16 21:12:05 UTC
mono-devel does provide /usr/lib64/pkgconfig/mono.pc on x86_64.

No. mono-libs-devel provides the mono.pc file

Comment 12 Paul F. Johnson 2006-08-23 11:03:07 UTC
Ping!

It looks like mono-debugger is going to be required for the next release of
MonoDevelop (due shortly) so this package could probably do with being looked at

Comment 13 Paul F. Johnson 2006-08-23 12:01:12 UTC
Spec URL: http://www.knox.net.nz/~nodoid/mono-debugger.spec
SRPM URL: http://www.knox.net.nz/~nodoid/mono-debugger-0.30-2.src.rpm

Removes the old mono hack
Rebuilt for new mono packages
Added BR mono-nunit
Added R pkgconfig for -devel


Comment 14 Paul F. Johnson 2006-08-27 10:06:58 UTC
Spec URL: http://www.knox.net.nz/~nodoid/mono-debugger.spec
SRPM URL: http://www.knox.net.nz/~nodoid/mono-debugger-0.30-3.src.rpm

Fixes correctly for 64 bit
Additional BRs (autoconf and automake)
Moved README.build to the -devel package
Fixed ownership problem on a directory

Comment 15 John Mahowald 2006-08-28 18:21:56 UTC
Better with the libdir fix, but still needs some work:
- Missing a %defattr entry for devel package
- Source0 is 404, looks like you want
http://go-mono.com/sources/mono-debugger/mono-debugger-0.30.tar.gz
- don't disable debug, there is debugging symbols.
- license is not LGPL, looks like MIT

Comment 16 Paul F. Johnson 2006-08-28 19:08:08 UTC
Spec URL: http://www.knox.net.nz/~nodoid/mono-debugger.spec

Fixes all from #15 - tar ball is the same

Comment 17 Paul F. Johnson 2006-08-28 21:30:31 UTC
Created attachment 135088 [details]
New spec file

Sorry had to put the new spec file here, but I can't seem to upload at the
moment

Comment 18 Paul F. Johnson 2006-08-28 21:41:21 UTC
Created attachment 135090 [details]
monodebug-configure patch

Comment 19 John Mahowald 2006-08-30 14:53:08 UTC
Doesn't build, needs a BuildRequires: libtool to get past autoreconf.

When it does build, I get:
E: mono-debugger shlib-with-non-pic-code /usr/lib64/libmonodebuggerreadline.so.0.0.0

Not sure why, the build log indicates compiling with -fPIC

Comment 20 Paul F. Johnson 2006-08-31 00:17:36 UTC
Created attachment 135251 [details]
Fixed spec file

Fixes the libtool problem. I can't reproduce the fPIC problem (though I thought
that problem was no longer a blocker or something like that)

Comment 21 John Mahowald 2006-09-02 01:22:20 UTC
+ License (MIT)
+ source matches upstream
+ builds fine on x86_64, with libdir patch
+ devel package with pkgconfig file
+ name-version-release follows guidelines
+ proper use of macros
+ proper file permissions
+ *.la files removed
+ proper clean section

APPROVED

Comment 22 Paul F. Johnson 2006-09-02 14:23:01 UTC
I've had to add excludearch-ppc to get it to build on the buildsys due to
missing definitions in the ppc %{_includedir}/sys/user.h file

Comment 23 Christian Iseli 2006-12-31 11:25:49 UTC
Please do not remove the FE-ACCEPT blocker.  Thanks.


Comment 24 David Woodhouse 2007-01-07 02:48:45 UTC
Is this package still excluded on PPC? If so, the bug on the FE-ExcludeArch-ppc
tracker shouldn't be closed. Please could you open a new bug if the package
still isn't working -- and then fix the bug too :)

Comment 25 Paul F. Johnson 2007-01-07 09:53:12 UTC
The bug is down to something missing in the PPC version of glibc (it's not been
ported across if memory serves me right). I did file a BZ report on it but was
told that the missing bit wasn't going to be implemented.

Comment 26 David Woodhouse 2007-01-07 10:23:10 UTC
What bugzilla number?

If the "something missing" is something that mono-debugger can't do without,
then it would be strange for the glibc bug to be closed 'wontfix'. If it's
something that mono-debugger _can_ do without, then mono-debugger should be fixed. 

Either way, there should be a bug filed against mono-debugger which
 a) Clearly explains the problem
 b) depends on the glibc bug you mention
 c) blocks FE-ExcludeArch-ppc


Comment 27 David Woodhouse 2007-01-07 10:48:35 UTC
Aha, it seems to be bug 205017. 


Note You need to log in before you can comment on or make changes to this bug.