Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 189250
| Summary: | Review Request: python-lxml - ElementTree-like python bindings for libxml2 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shahms E. King <shahms> |
| Component: | Package Review | Assignee: | Paul Nasrat <nobody+pnasrat> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jeff, nobody+pnasrat |
| Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-04-28 16:47:59 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Shahms E. King
2006-04-18 15:45:32 UTC
rpmlint fails (warning and error): rpmlint python-lxml-0.9.1-1.src.rpm W: python-lxml summary-ended-with-dot ElementTree-like Python bindings for libxml2 and libxslt. E: python-lxml description-line-too-long lxml provides a Python binding to the libxslt and libxml2 libraries. It follows Can you fix those up and we'll start again. Fixed. The new files are at: http://shahms.mesd.k12.or.us/packages/python-lxml.spec http://shahms.mesd.k12.or.us/packages/python-lxml-0.9.1-2.src.rpm Thanks for that. Two suggestions but otherwise looking good to me. Please add a BuildRequires python-setuptools as mock build fails without this. Suggest use of dist tag - but not necessary for acceptance Review: * built on fc5 - tested in v * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written, uses macros consistently and conforms to the python template. * license field matches the actual license. * license is open source-compatible and included * source files match upstream: 25e18d86050907f3a088550fe650f841 lxml-0.9.1.tgz 25e18d86050907f3a088550fe650f841 /home/pauln/tmp/lxml-0.9.1.tgz * rpmlint is silent. * BuildRequires sane, although not sufficient for mock. * final provides and requires are sane. * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is not present * package contains code, not content. * documentation is relatively small , so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no pkgconfig files. * no libtool .la files * not a GUI app so no .desktop Thanks for reviewing the package. I could have sworn I'd added both the dist tag and BuildRequires, but that's why we have reviewers ;-). I've made the suggested changes and put up new files at: http://shahms.mesd.k12.or.us/packages/python-lxml.spec http://shahms.mesd.k12.or.us/packages/python-lxml-0.9.1-3.src.rpm Thanks - builds and runs. Meets review criteria, moving to FE-ACCEPT
>>> import lxml.etree
>>> doc = lxml.etree.parse('example-tutorial-en.xml')
>>> e = doc.xpath('//article[@id="example-tutorial"]')
>>> e
[<Element article at -480fd9e4>
Review as above:
* built on fc5 - tested working
* package meets naming and packaging guidelines. Uses dist tag.
* specfile is properly named, is cleanly written, uses macros consistently and
conforms to the python template.
* license field matches the actual license.
* license is open source-compatible and included
* source files match upstream:
25e18d86050907f3a088550fe650f841 lxml-0.9.1.tgz
25e18d86050907f3a088550fe650f841 /home/pauln/tmp/lxml-0.9.1.tgz
* BuildRequires are proper.
* builds in mock
* rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is not present
* package contains code, not content.
* documentation is relatively small , so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no pkgconfig files.
* no libtool .la files
* not a GUI app so no .desktop
Package Change Request ====================== Package Name: python-lxml Updated Fedora Owners: shahms,jeff ACK is in bug 245690. CVS done. Package Change Request ====================== Package Name: python-lxml New Branches: EL-4 EL-5 Updated EPEL Owners: jeff Oops, forget to set the CVS flag... Package Change Request ====================== Package Name: python-lxml New Branches: EL-4 EL-5 Updated EPEL Owners: jeff cvs done. |