Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 189824
Summary: | Review Request: lasi - C++ library for creating Postscript documents | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
Component: | Package Review | Assignee: | Gérard Milmeister <gemi> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://www.cora.nwra.com/~orion/fedora/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-05-08 18:21:33 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Orion Poplawski
2006-04-24 21:41:29 UTC
First the good news: no complaints from rpmlint. Now for the nitpicks:-) 1. The doc directory properly belong in the -devel package, since it is API documentation. 2. In %description I would use LASi instead of libLASi since that is the name. 3. The -devel package needs Requires: pango-devel and freetype-devel These are included in LASi.h (In reply to comment #1) > 1. The doc directory properly belong in the -devel package, since > it is API documentation. Done. > 2. In %description I would use LASi instead of libLASi since that > is the name. Done. > 3. The -devel package needs Requires: pango-devel and freetype-devel > These are included in LASi.h Added pango-devel, which in turn requires freetype-devel. Updated to 1.0.5 which fixes several issues. http://www.cora.nwra.com/~orion/fedora/lasi-1.0.5-1.fc5.src.rpm One small issue: the summary of lasi-devel should end with a period. Another issue which is probably a mistake by upstream: "pkg-config --libs lasi" returns the empty string instead of -lLASi Looking at the examples, "-lLASi" is always explicitly included in the compile command. Also, the policy of FE is to omit static libraries, see "Static Libraries" in http://fedoraproject.org/wiki/Packaging/Guidelines (In reply to comment #3) > One small issue: the summary of lasi-devel should end with a period. Fixed. > Another issue which is probably a mistake by upstream: > "pkg-config --libs lasi" returns the empty string instead of -lLASi > Looking at the examples, "-lLASi" is always explicitly included in > the compile command. Patched and submitted upstream. > Also, the policy of FE is to omit static libraries, see "Static Libraries" in > http://fedoraproject.org/wiki/Packaging/Guidelines Gah, I can't believe I did this! Thanks for catching. Fixed. http://www.cora.nwra.com/~orion/fedora/lasi-1.0.5-2.fc5.src.rpm APPROVED Checked in. Added to owners.list Built on devel. FC-4 and FC-5 to come shortly. |