Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 189824 - Review Request: lasi - C++ library for creating Postscript documents
Summary: Review Request: lasi - C++ library for creating Postscript documents
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Gérard Milmeister
QA Contact: Fedora Package Reviews List
URL: http://www.cora.nwra.com/~orion/fedora/
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-04-24 21:41 UTC by Orion Poplawski
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-05-08 18:21:33 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Orion Poplawski 2006-04-24 21:41:29 UTC 
This is needed for the psttf driver for the upcoming 5.6.0 release of plplot.

Spec Name or Url: http://www.cora.nwra.com/~orion/fedora/lasi.spec
SRPM Name or Url: http://www.cora.nwra.com/~orion/fedora/lasi-1.0.4-1.src.rpm
Description: 
libLASi is a library written by Larry Siden  that provides a C++ stream
output interface ( with operator << ) for creating Postscript documents that
can contain characters from any of the scripts and symbol blocks supported in
Unicode  and by Owen Taylor's Pango layout engine. The library accomodates
right-to-left scripts such as Arabic and Hebrew as easily as left-to-right
scripts. Indic and Indic-derived Complex Text Layout (CTL) scripts, such as
Devanagari, Thai, Lao, and Tibetan are supported to the extent provided by
Pango and by the OpenType fonts installed on your system. All of this is
provided without need for any special configuration or layout calculation on
the programmer's part.

Although the capability to produce Unicode-based multilingual Postscript
documents exists in large Open Source application framework libraries such as
GTK+, QT, and KDE, libLASi was designed for projects which require the
ability to produce Postscript independent of any one application framework.
Comment 1 Gérard Milmeister 2006-04-30 23:54:38 UTC 
First the good news: no complaints from rpmlint.
Now for the nitpicks:-)
1. The doc directory properly belong in the -devel package, since
   it is API documentation.
2. In %description I would use LASi instead of libLASi since that
   is the name.
3. The -devel package needs Requires: pango-devel and freetype-devel
   These are included in LASi.h
Comment 2 Orion Poplawski 2006-05-04 17:23:42 UTC 
(In reply to comment #1)
> 1. The doc directory properly belong in the -devel package, since
>    it is API documentation.

Done.

> 2. In %description I would use LASi instead of libLASi since that
>    is the name.

Done.

> 3. The -devel package needs Requires: pango-devel and freetype-devel
>    These are included in LASi.h

Added pango-devel, which in turn requires freetype-devel.

Updated to 1.0.5 which fixes several issues.

http://www.cora.nwra.com/~orion/fedora/lasi-1.0.5-1.fc5.src.rpm
Comment 3 Gérard Milmeister 2006-05-06 20:11:08 UTC 
One small issue: the summary of lasi-devel should end with a period.

Another issue which is probably a mistake by upstream:
"pkg-config --libs lasi" returns the empty string instead of -lLASi
Looking at the examples, "-lLASi" is always explicitly included in
the compile command.

Also, the policy of FE is to omit static libraries, see "Static Libraries" in
http://fedoraproject.org/wiki/Packaging/Guidelines
Comment 4 Orion Poplawski 2006-05-08 15:57:00 UTC 
(In reply to comment #3)
> One small issue: the summary of lasi-devel should end with a period.

Fixed.

> Another issue which is probably a mistake by upstream:
> "pkg-config --libs lasi" returns the empty string instead of -lLASi
> Looking at the examples, "-lLASi" is always explicitly included in
> the compile command.

Patched and submitted upstream.
 
> Also, the policy of FE is to omit static libraries, see "Static Libraries" in
> http://fedoraproject.org/wiki/Packaging/Guidelines

Gah, I can't believe I did this!  Thanks for catching.  Fixed.

http://www.cora.nwra.com/~orion/fedora/lasi-1.0.5-2.fc5.src.rpm
Comment 5 Gérard Milmeister 2006-05-08 18:05:04 UTC 
APPROVED
Comment 6 Orion Poplawski 2006-05-08 18:21:33 UTC 
Checked in.
Added to owners.list
Built on devel.
FC-4 and FC-5 to come shortly.
Note You need to log in before you can comment on or make changes to this bug.