Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 189886
| Summary: | Review Request: FluidSynth - Real-time software synthesizer | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Anthony Green <green> |
| Component: | Package Review | Assignee: | Hans de Goede <hdegoede> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | nando, seg |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-07-15 03:07:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 189884 | ||
| Bug Blocks: | 163779, 191538 | ||
|
Description
Anthony Green
2006-04-25 15:16:18 UTC
Unnecessary build dependence e2fsprogs-devel. (In reply to comment #1) > Unnecessary build dependence e2fsprogs-devel. Thanks. Fixed. Spec URL: http://people.redhat.com/green/FE/FC5/fluidsynth.spec SRPM URL: http://people.redhat.com/green/FE/FC5/fluidsynth-1.0.7a-4.src.rpm MUST: ===== 0 rpmlint output is: E: fluidsynth obsolete-not-provided iiwusynth E: libfluidsynth-devel obsolete-not-provided libiiwusynth-devel These both must be fixed. * Package and spec file named appropriately * Packaged according to packaging guidelines 0 License (LGPL) ok, but license file not included! * spec file is legible and in Am. English. * Source matches upstream * Compiles and builds on devel-i386 * BR: ok * No locales * shared libraries, ldconfig properly ran * Not relocatable * Package owns / or requires all dirs (with some strangeness see Must fix below) * No duplicate files & Permissions ok * %clean & macro usage OK * Contains code only 0 no %doc * -devel package as needed 0 .la files packaged, bad! * no gui -> no .desktop file required MUST fix: ========= * Alphanumeric parts of the version should be in the Release field, as per: http://fedoraproject.org/wiki/Packaging/NamingGuidelines Then you can drop the "-n fluidsynth-1.0.7" to %setup too * Dont use %package -n lib%{name} thats very Debian afaik (allmost) all Fedora package use %package libs same goes for the devel package. * The following rpmlint output: E: fluidsynth obsolete-not-provided iiwusynth E: libfluidsynth-devel obsolete-not-provided libiiwusynth-devel * Don't package .la files, remove them under %install or %exclude them in %files * Add a %doc including atleast COPYING, but mosty likely also other candidates (In reply to comment #3) > 0 rpmlint output is: > E: fluidsynth obsolete-not-provided iiwusynth > E: libfluidsynth-devel obsolete-not-provided libiiwusynth-devel Fixed. > 0 License (LGPL) ok, but license file not included! Fixed. > 0 no %doc Fixed. > 0 .la files packaged, bad! Fixed. > * Alphanumeric parts of the version should be in the Release field, as per: > http://fedoraproject.org/wiki/Packaging/NamingGuidelines > Then you can drop the "-n fluidsynth-1.0.7" to %setup too Fixed. > * Dont use %package -n lib%{name} thats very Debian afaik (allmost) all Fedora > package use %package libs same goes for the devel package. Fixed. > * The following rpmlint output: > E: fluidsynth obsolete-not-provided iiwusynth > E: libfluidsynth-devel obsolete-not-provided libiiwusynth-devel > * Don't package .la files, remove them under %install or %exclude them in %files > * Add a %doc including atleast COPYING, but mosty likely also other candidates Fixed, as above. Thanks for your effort. Sorry for the delay. Updates bits here: Spec URL: http://people.redhat.com/green/FE/FC5/fluidsynth.spec SRPM URL: http://people.redhat.com/green/FE/FC5/fluidsynth-1.0.7-5.a.src.rpm Looks good, approved! Thanks. AG. |