Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 189886 - Review Request: FluidSynth - Real-time software synthesizer
Summary: Review Request: FluidSynth - Real-time software synthesizer
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Hans de Goede
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: 189884
Blocks: FE-ACCEPT 191538
TreeView+ depends on / blocked
 
Reported: 2006-04-25 15:16 UTC by Anthony Green
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-07-15 03:07:36 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Anthony Green 2006-04-25 15:16:18 UTC 
Spec URL: http://people.redhat.com/green/FE/FC5/fluidsynth.spec
SRPM URL: http://people.redhat.com/green/FE/FC5/fluidsynth-1.0.7a-3.src.rpm
Description: 
FluidSynth is a real-time software synthesizer based on the SoundFont
2 specifications. It is a "software synthesizer". FluidSynth can read
MIDI events from the MIDI input device and render them to the audio
device. It can also play MIDI files (note: FluidSynth was previously
called IIWU Synth).
Comment 1 Konstantin Korikov 2006-05-27 14:54:48 UTC 
Unnecessary build dependence e2fsprogs-devel.
Comment 2 Anthony Green 2006-05-28 00:10:12 UTC 
(In reply to comment #1)
> Unnecessary build dependence e2fsprogs-devel.

Thanks.  Fixed.

Spec URL: http://people.redhat.com/green/FE/FC5/fluidsynth.spec
SRPM URL: http://people.redhat.com/green/FE/FC5/fluidsynth-1.0.7a-4.src.rpm
Comment 3 Hans de Goede 2006-06-15 11:47:31 UTC 
MUST:
=====
0 rpmlint output is:
E: fluidsynth obsolete-not-provided iiwusynth
E: libfluidsynth-devel obsolete-not-provided libiiwusynth-devel
These both must be fixed.
* Package and spec file named appropriately
* Packaged according to packaging guidelines
0 License (LGPL) ok, but license file not included!
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel-i386
* BR: ok
* No locales
* shared libraries, ldconfig properly ran
* Not relocatable
* Package owns / or requires all dirs (with some strangeness see Must fix below)
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code only
0 no %doc
* -devel package as needed
0 .la files packaged, bad!
* no gui -> no .desktop file required


MUST fix:
=========
* Alphanumeric parts of the version should be in the Release field, as per:
 http://fedoraproject.org/wiki/Packaging/NamingGuidelines
 Then you can drop the "-n fluidsynth-1.0.7" to %setup too
* Dont use %package -n lib%{name} thats very Debian afaik (allmost) all Fedora
  package use %package libs same goes for the devel package.
* The following rpmlint output:
E: fluidsynth obsolete-not-provided iiwusynth
E: libfluidsynth-devel obsolete-not-provided libiiwusynth-devel
* Don't package .la files, remove them under %install or %exclude them in %files
* Add a %doc including atleast COPYING, but mosty likely also other candidates
Comment 4 Anthony Green 2006-07-14 04:09:21 UTC 
(In reply to comment #3)
> 0 rpmlint output is:
> E: fluidsynth obsolete-not-provided iiwusynth
> E: libfluidsynth-devel obsolete-not-provided libiiwusynth-devel

Fixed.

> 0 License (LGPL) ok, but license file not included!

Fixed.

> 0 no %doc

Fixed.

> 0 .la files packaged, bad!

Fixed.

> * Alphanumeric parts of the version should be in the Release field, as per:
>  http://fedoraproject.org/wiki/Packaging/NamingGuidelines
>  Then you can drop the "-n fluidsynth-1.0.7" to %setup too

Fixed.

> * Dont use %package -n lib%{name} thats very Debian afaik (allmost) all Fedora
>   package use %package libs same goes for the devel package.

Fixed.

> * The following rpmlint output:
> E: fluidsynth obsolete-not-provided iiwusynth
> E: libfluidsynth-devel obsolete-not-provided libiiwusynth-devel
> * Don't package .la files, remove them under %install or %exclude them in %files
> * Add a %doc including atleast COPYING, but mosty likely also other candidates

Fixed, as above.

Thanks for your effort. Sorry for the delay.

Updates bits here:
Spec URL: http://people.redhat.com/green/FE/FC5/fluidsynth.spec
SRPM URL: http://people.redhat.com/green/FE/FC5/fluidsynth-1.0.7-5.a.src.rpm
Comment 5 Hans de Goede 2006-07-14 21:35:42 UTC 
Looks good, approved!
Comment 6 Anthony Green 2006-07-15 03:07:36 UTC 
Thanks.  AG.
Note You need to log in before you can comment on or make changes to this bug.