Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 189891
Summary: | Review Request: liblo - Open Sound Control library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Anthony Green <green> |
Component: | Package Review | Assignee: | Jochen Schmitt <jochen> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | seg |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-05-14 21:20:47 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Anthony Green
2006-04-25 15:31:49 UTC
God: + Local build works fine. + Source in the rpm are the same as upstream. + Build on mock works fine. + rpmlint of source rpm ok. + rpmlint of binaries rpms ok. ü can start example_server and example_client without a crash Bad: - The BuildRoot must be cleaned at the beginning of %install - Thanks for looking at this. (In reply to comment #1) > Bad: > - The BuildRoot must be cleaned at the beginning of %install > - It is, isn't it? The spec file reads... %install %{__rm} -rf %{buildroot} %{__make} DESTDIR=%{buildroot} install Whats the point of macros such as %{__rm} and %{__make}? I've seen them in some packages and have never quite understood why they exist. Fedora wiki doesn't say anything about them that I've seen. (And the spec template doesn't use them...) My personal preference is to avoid macros. (In reply to comment #3) > Whats the point of macros such as %{__rm} and %{__make}? I have no idea, and always wondered this myself. I'm guessing at one time there was a policy to never invoke commands directly in spec files so everything can be overridden by redefining macros. If that's the case I'd definately lose them. :) (In reply to comment #5) > If that's the case I'd definately lose them. :) Done... Spec URL: http://people.redhat.com/green/FE/FC5/liblo.spec SRPM URL: http://people.redhat.com/green/FE/FC5/liblo-0.23-4.src.rpm I'm happy to inform you, that your package is approved. Thanks! |