Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 189891 - Review Request: liblo - Open Sound Control library
Summary: Review Request: liblo - Open Sound Control library
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jochen Schmitt
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-04-25 15:31 UTC by Anthony Green
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-05-14 21:20:47 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Anthony Green 2006-04-25 15:31:49 UTC
Spec URL: http://people.redhat.com/green/FE/FC5/liblo.spec
SRPM URL: http://people.redhat.com/green/FE/FC5/liblo-0.23-3.src.rpm
Description: 
liblo is an implementation of the Open Sound Control protocol for
POSIX systems developed by Steve Harris.

Adapted from an old ccrma spec file.

Comment 1 Jochen Schmitt 2006-04-25 16:35:49 UTC
God:
+ Local build works fine.
+ Source in the rpm are the same as upstream.
+ Build on mock works fine.
+ rpmlint of source rpm ok.
+ rpmlint of binaries rpms ok.
ü can start example_server and example_client without a crash


Bad:
- The BuildRoot must be cleaned at the beginning of %install
- 


Comment 2 Anthony Green 2006-04-26 14:58:06 UTC
Thanks for looking at this.

(In reply to comment #1)
> Bad:
> - The BuildRoot must be cleaned at the beginning of %install
> - 

It is, isn't it?  The spec file reads...

%install
%{__rm} -rf %{buildroot}
%{__make} DESTDIR=%{buildroot} install




Comment 3 Callum Lerwick 2006-04-29 08:02:54 UTC
Whats the point of macros such as %{__rm} and %{__make}? I've seen them in some
packages and have never quite understood why they exist. Fedora wiki doesn't say
anything about them that I've seen. (And the spec template doesn't use them...)

My personal preference is to avoid macros.

Comment 4 Anthony Green 2006-04-29 12:33:41 UTC
(In reply to comment #3)
> Whats the point of macros such as %{__rm} and %{__make}? 

I have no idea, and always wondered this myself.  I'm guessing at one time there
was a policy to never invoke commands directly in spec files so everything can
be overridden by redefining macros.  

Comment 5 Callum Lerwick 2006-04-29 18:16:17 UTC
If that's the case I'd definately lose them. :)

Comment 6 Anthony Green 2006-04-29 19:27:32 UTC
(In reply to comment #5)
> If that's the case I'd definately lose them. :)

Done...

Spec URL: http://people.redhat.com/green/FE/FC5/liblo.spec
SRPM URL: http://people.redhat.com/green/FE/FC5/liblo-0.23-4.src.rpm

Comment 7 Jochen Schmitt 2006-05-14 18:42:24 UTC
I'm happy to inform you, that your package is approved.

Comment 8 Anthony Green 2006-05-14 21:20:47 UTC
Thanks!



Note You need to log in before you can comment on or make changes to this bug.