Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 191130
Summary: | Review Request: kmobiletools | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Dennis Gilmore <dennis> |
Component: | Package Review | Assignee: | Michael J Knox <michael> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | rdieter |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-07-21 21:47:13 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Dennis Gilmore
2006-05-09 02:30:27 UTC
DEFINE QT Dirs to ensure build is ok Spec URL: http://ausil.us/packages/kmobiletools.spec SRPM URL: http://www.ausil.us/packages/kmobiletools-0.4.3.3-2.src.rpm also not 100% sure is I should include a udev ruleset. the couple of mobile phones i have tried use /dev/ttyACM0 which gets [dennis@rpclnx001 SPECS]$ ls -la /dev/ttyACM0 crw-rw---- 1 root uucp 166, 0 May 9 08:32 /dev/ttyACM0 so the user cant access the phone. the two things that can make it easier is 1 making the owner the logged in user or 2 make the users needing access members of the uucp group As a mobile phone user, I think this would be a great tool to add. I am trying moto4lin which works with my Motorla phone but it would be better to have a full tools available. kmobiletools doesnt do everything. it does not provide a way to put pictures and files on you phone or to take them off. It allows you to manage sms and phone book Hello.. I will review this package for you.. ---------------------------------------- Review for release 2: * RPM name is OK * Source kmobiletools-0.4.3.3.tar.bz2 is the same as upstream * This is the latest version * Builds fine in mock * rpmlint looks OK * File list looks OK Needs work: * Scriptlets: missing "gtk-update-icon-cache" in %post (wiki: ScriptletSnippets) * Scriptlets: missing "gtk-update-icon-cache" in %postun (wiki: ScriptletSnippets) Package looks pretty good. If you fix up the %post/%postun scriplets, I can approve this submission. I wont fix the %post/%postun there is no need to add gnome cruft to a kde package. and as has been stated in quite a few package reviews and there is a bug filed gtk-update-icon-cache should be run as a cron job not in packages. Re: comment #5. I support Dennis' comment. The fdo icon spec only requires "touch"ing the affected icon dirs. OK then. I am just following the guidelines :-) However, I will APPROVE the submission as is. Please do not forget to close this review once its been imported into CVS. thanks for the review, branched and built will go out with next push |