Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 191130 - Review Request: kmobiletools
Summary: Review Request: kmobiletools
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michael J Knox
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-05-09 02:30 UTC by Dennis Gilmore
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-07-21 21:47:13 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Dennis Gilmore 2006-05-09 02:30:27 UTC 
Spec URL: http://ausil.us/packages/kmobiletools.spec
SRPM URL: http://ausil.us/packages/kmobiletools-0.4.3.3-1.fc5.src.rpm
Description: 
KMobileTools is a KDE application that allows you to control your mobile phone
from your GNU/Linux workstation

To use KMobileTools you need a mobile phone, that can be attached to your PC
using any type of connection (serial, USB, bluetooth and irda were tested
successfully), and using an AT interface (modem-like)
Comment 1 Dennis Gilmore 2006-05-09 13:47:22 UTC 
DEFINE QT Dirs to ensure  build is ok
Spec URL: http://ausil.us/packages/kmobiletools.spec
SRPM URL: http://www.ausil.us/packages/kmobiletools-0.4.3.3-2.src.rpm

also not 100% sure is I should include a udev ruleset.  the couple of mobile 
phones i have tried use /dev/ttyACM0  which gets 
[dennis@rpclnx001 SPECS]$ ls -la /dev/ttyACM0
crw-rw---- 1 root uucp 166, 0 May  9 08:32 /dev/ttyACM0

so the user cant access the phone. the two  things  that can make it easier is  
1 making the owner  the logged in user  or 
2 make the users  needing access members of the uucp group
Comment 2 Robin Laing 2006-05-17 22:42:23 UTC 
As a mobile phone user, I think this would be a great tool to add.  I am trying
moto4lin which works with my Motorla phone but it would be better to have a full
tools available.
Comment 3 Dennis Gilmore 2006-05-18 03:18:29 UTC 
kmobiletools doesnt do everything.  it does not provide a way to put pictures 
and files on you phone or to take them off.  It allows you to manage sms and 
phone book
Comment 4 Michael J Knox 2006-07-21 08:48:10 UTC 
Hello.. I will review this package for you.. 

----------------------------------------

Review for release 2:

* RPM name is OK
* Source kmobiletools-0.4.3.3.tar.bz2 is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint looks OK
* File list looks OK

Needs work:
* Scriptlets: missing "gtk-update-icon-cache" in %post (wiki: ScriptletSnippets)
* Scriptlets: missing "gtk-update-icon-cache" in %postun (wiki: ScriptletSnippets)

Package looks pretty good. If you fix up the %post/%postun scriplets, I can
approve this submission.
Comment 5 Dennis Gilmore 2006-07-21 11:14:27 UTC 
I wont fix  the %post/%postun  there is no need to add gnome cruft to a kde 
package.  and as has been stated in quite a few package reviews  and there is 
a bug filed  gtk-update-icon-cache   should be run as a cron job  not in 
packages.
Comment 6 Rex Dieter 2006-07-21 11:23:10 UTC 
Re: comment #5.  I support Dennis' comment.  The fdo icon spec only requires
"touch"ing the affected icon dirs.
Comment 7 Michael J Knox 2006-07-21 20:31:29 UTC 
OK then. I am just following the guidelines :-) 

However, I will APPROVE the submission as is. Please do not forget to close this
review once its been imported into CVS.
Comment 8 Dennis Gilmore 2006-07-21 21:47:13 UTC 
thanks for the review,  branched and built will go out with next push
Note You need to log in before you can comment on or make changes to this bug.