Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 191605
Summary: | Review Request: lineak-defaultplugin - default actions for lineakd | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Petersen <lists> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-05-24 05:34:13 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 191604 | ||
Bug Blocks: | 163779 |
Description
Chris Petersen
2006-05-13 19:42:37 UTC
Shuffling files around on my server, and making a few changes to bring things up to par. http://rpm.forevermore.net/lineak/lineak_defaultplugin.spec http://rpm.forevermore.net/lineak/lineak_defaultplugin-0.8.4-2.src.rpm More changes, ala request: http://rpm.forevermore.net/lineak/lineak-defaultplugin.spec http://rpm.forevermore.net/lineak/lineak-defaultplugin-0.8.4-3.src.rpm This fails to build in mock on both i386 and x86_64; I have no idea why. The build log ends with: checking Looking for lineak headers... /usr/include/lineak checking for X... no checking for ac_check_lineak in -llineak... no configure: error: lib lineak not found. Please install lineakd 0.8 or later. error: Bad exit status from /var/tmp/rpm-tmp.60358 (%build) I have verified that /usr/lib(64)?/liblineak.so exists and the ac_check_lineak symbol is there. Now %configure succeeds, but the build fails due to a missing BR: libxkbfile-devel. Adding that gets me through the build. For the purposes of this review, I'll assume that it's there since there's no point in another round; you can fix it when you check in. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * license field matches the actual license. * license is open source-compatible. License text included in package. * source files match upstream: 336b4fa5aa40b1166c2aa5418740357b lineak_defaultplugin-0.8.4.tar.gz 336b4fa5aa40b1166c2aa5418740357b lineak_defaultplugin-0.8.4.tar.gz-srpm * latest version is being packaged. * BuildRequires are proper (after adding libxkbfile-devel). * package builds in mock (development, x86_64) (after adding libxkbfile-devel). * rpmlint is silent. * final provides and requires are sane: config(lineak-defaultplugin) = 0.8.4-4.fc6 defaultplugin.so()(64bit) lineak_defaultplugin = 0.8.4 mediadetectplugin.so()(64bit) lineak-defaultplugin = 0.8.4-4.fc6 - config(lineak-defaultplugin) = 0.8.4-4.fc6 libX11.so.6()(64bit) libXext.so.6()(64bit) libXtst.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) liblineak.so.0()(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) lineakd = 0.8.4 * shared libraries are present, but internal to lineakd so ldconfig isn't called. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is not present; no test suite upstream. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED |