Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 191605 - Review Request: lineak-defaultplugin - default actions for lineakd
Summary: Review Request: lineak-defaultplugin - default actions for lineakd
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On: 191604
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-05-13 19:42 UTC by Chris Petersen
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-05-24 05:34:13 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Chris Petersen 2006-05-13 19:42:37 UTC
Spec URL: http://forevermore.net/files/packages/lineak/lineak_defaultplugin.spec
SRPM URL: http://forevermore.net/files/packages/lineak/lineak_defaultplugin-0.8.4-1.src.rpm
Description: 

Plugin for lineakd that contains most of its default actions.

Comment 2 Chris Petersen 2006-05-21 08:41:31 UTC
Shuffling files around on my server, and making a few changes to bring things up
to par.

http://rpm.forevermore.net/lineak/lineak_defaultplugin.spec
http://rpm.forevermore.net/lineak/lineak_defaultplugin-0.8.4-2.src.rpm

Comment 4 Jason Tibbitts 2006-05-23 03:46:48 UTC
This fails to build in mock on both i386 and x86_64; I have no idea why.  The
build log ends with:

checking Looking for lineak headers... /usr/include/lineak
checking for X... no
checking for ac_check_lineak in -llineak... no
configure: error: lib lineak not found. Please install lineakd 0.8 or later.
error: Bad exit status from /var/tmp/rpm-tmp.60358 (%build)

I have verified that /usr/lib(64)?/liblineak.so exists and the ac_check_lineak
symbol is there.


Comment 6 Jason Tibbitts 2006-05-24 03:41:14 UTC
Now %configure succeeds, but the build fails due to a missing BR:
libxkbfile-devel.  Adding that gets me through the build.  For the purposes of
this review, I'll assume that it's there since there's no point in another
round; you can fix it when you check in.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* source files match upstream:
   336b4fa5aa40b1166c2aa5418740357b  lineak_defaultplugin-0.8.4.tar.gz
   336b4fa5aa40b1166c2aa5418740357b  lineak_defaultplugin-0.8.4.tar.gz-srpm
* latest version is being packaged.
* BuildRequires are proper (after adding libxkbfile-devel).
* package builds in mock (development, x86_64) (after adding libxkbfile-devel).
* rpmlint is silent.
* final provides and requires are sane:
   config(lineak-defaultplugin) = 0.8.4-4.fc6
   defaultplugin.so()(64bit)
   lineak_defaultplugin = 0.8.4
   mediadetectplugin.so()(64bit)
   lineak-defaultplugin = 0.8.4-4.fc6
  -
   config(lineak-defaultplugin) = 0.8.4-4.fc6
   libX11.so.6()(64bit)
   libXext.so.6()(64bit)
   libXtst.so.6()(64bit)
   libdl.so.2()(64bit)
   libgcc_s.so.1()(64bit)
   liblineak.so.0()(64bit)
   libm.so.6()(64bit)
   libstdc++.so.6()(64bit)
   libstdc++.so.6(CXXABI_1.3)(64bit)
   libstdc++.so.6(GLIBCXX_3.4)(64bit)
   lineakd = 0.8.4

* shared libraries are present, but internal to lineakd so ldconfig isn't called.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is not present; no test suite upstream.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED


Note You need to log in before you can comment on or make changes to this bug.