Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 193804
| Summary: | Review Request: glitz | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Eric Work <work.eric> |
| Component: | Package Review | Assignee: | Ralf Corsepius <rc040203> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-06-08 22:11:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779, 192436 | ||
|
Description
Eric Work
2006-06-01 18:42:00 UTC
Some comments: * IMO, it should be considered to split this package into 2 subpackages: glitz and glitz-glx, because the package internally consists of libglitz and several backends, with libglitz-glx being one them. Splitting it would allow more fine-grained deps, and thereby would help avoid unnecessary deps of apps/libs based on glitz. * The deps of the devel package don't seem to be correct: - libglitz doesn't seem to depend on any X or GL library. - libglitz-glx seems to depend libX11-devel and libGL-devel, but not on further libX*-devel, in particular it doesn't not depend on libXt-devel. * The package ships manpages, but doesn't install them. May-be it's worth considering to install them. * The configure script carries several options defaulting to true: --disable-glx Disable glitz's GLX backend --disable-agl Disable glitz's AGL backend --enable-egl Enable glitz's EGL backend --disable-wgl Disable glitz's WGL backend This will render building this package outside of a chroot-environment non-deterministic, should one of these GL backends land in Fedora. I.e. I recommend to add --enable-glx --disable-agl --disable-egl --disable-wgl to %configure I will be gone this weekend, but I will work on these issues in the near future and update the packages for re-evaluation. Thanks for the feedback. Updated the SPEC with your recommendations. SPEC file: http://www.ece.ucdavis.edu/~ewwork/repo/testing/SPECS/glitz.spec SRPM file: http://www.ece.ucdavis.edu/~ewwork/repo/testing/SRPMS/glitz-0.5.6-2.src.rpm Some issues:
- glitz-devel contains pkg-config files, it therefore should
Requires: pkgconfig
- glitz-glx-devel contains pkg-config files, it therefore should
Requires: pkgconfig
- glitz-glx-devel depends on glitz-devel, it therefore must
Requires: glitz-devel
or
Requires: glitz-devel = %{version}-%{release}
- man3 manpages are programming manuals.
They should be part of the *-devel packages.
Updated package. SPEC files: http://www.ece.ucdavis.edu/~ewwork/repo/testing/SPECS/glitz.spec SRPM file: http://www.ece.ucdavis.edu/~ewwork/repo/testing/SRPMS/glitz-0.5.6-3.src.rpm APPROVED. |