Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 195393
Summary: | Review Request: pyxmms | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Paul F. Johnson <paul> | ||||
Component: | Package Review | Assignee: | Kevin Fenzi <kevin> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | ||||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2006-06-20 08:27:28 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 163779, 195394 | ||||||
Attachments: |
|
Description
Paul F. Johnson
2006-06-14 23:06:33 UTC
OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 4c49fe60326874e90cc0bf75a10f63d7 pyxmms-2.06.tar.bz2 4c49fe60326874e90cc0bf75a10f63d7 pyxmms-2.06.tar.bz2.1 OK - Package compiles and builds on at least one arch. n/a - Package needs ExcludeArch OK - BuildRequires correct n/a - Spec handles locales/find_lang n/a - Spec has needed ldconfig in post and postun n/a - Package is relocatable and has a reason to be. OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. n/a - -doc subpackage needed/used. OK - Packages %doc files don't affect runtime. n/a - Headers/static libs in -devel subpackage. n/a - .pc files in -devel subpackage. n/a - .so files in -devel subpackage. n/a - -devel package Requires: %{name} = %{version}-%{release} n/a - .la files are removed. n/a - Package is a GUI app and has a .desktop file OK - Package doesn't own any directories other packages own. OK - No rpmlint output. Issues: 1. %file should probibly have: %ghost %{python_sitelib}/xmms/*.pyo per the python packaging page. Fix that up and this package will be APPROVED. Created attachment 131174 [details]
spec file
looks good to me. APPROVED. Remember to close this as NEXTRELEASE once it's imported and built. A couple of points: 1. Simply adding "%ghost /%{python_sitelib}/xmms/*.pyo" is not sufficient since the .pyo files are already included in the package courtesy of the previous line "/%{python_sitearch}/xmms/". The standard idiom for this is: %dir %{python_sitearch}/xmms/ %{python_sitearch}/xmms/*.py %{python_sitearch}/xmms/*.pyc %ghost %{python_sitearch}/xmms/*.pyo In this case it will also be necessary to have: %{python_sitearch}/xmms/*.so Note that no leading slash is necessary for %{python_sitearch} as the macro expansion includes one already. 2. The version of the package imported into cvs does not have the spec file from Comment #2. Please be more careful about what you import into cvs (and build?). Comment #2 was a test spec - I should have pointed that out. The one in cvs is the correct one. I'll amend the spec as suggested in #4, test and upload tonight. |