Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1959484
| Summary: | FTBFS: galera 26.4.8; galera-25.3.33 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michal Schorm <mschorm> |
| Component: | galera | Assignee: | Lukas Javorsky <ljavorsk> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | damien.ciabrini, fdinitto, hhorak, ljavorsk, mbayer, mschorm |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | galera-26.4.8-1.fc34 galera-26.4.8-1.fc33 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-06-11 01:15:28 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Michal Schorm
2021-05-11 15:55:18 UTC
PRs: https://src.fedoraproject.org/rpms/galera/pull-request/6 https://src.fedoraproject.org/rpms/galera/pull-request/5 Scratch-builds: 25.3.33: https://koji.fedoraproject.org/koji/taskinfo?taskID=69609920 26.4.8: https://koji.fedoraproject.org/koji/taskinfo?taskID=69225761 The fix for the issue described in my initial comment seems OK. Though, I don't see any comment, or better - explanation - why is the fix needed. 1) Is this issue reported upstream; or by chance, already fixed? If not, we should notify the upstream. 2) I would assume, the upstream runs the same tests. Why they haven't encountered an issue? 3) What did you find was the core of the issue? Based on the fix you propose, it seems like the Galera code is fine and the problem is in the test-suite. However without a description it is hard to check if it actually isn't the other way around by any chance. 4) I'd advise to split the commit into two commits. You are doing two separate things - first one is the rebase itself; second one is the fix of the test. Direct benefit is the clarity of the resulting code updates, secondary benefit may come e.g. when the fix won't be needed any longer, and we can just call "git revert" on it, and target only what we intend (without the rebase part) 1) I found the issue reported on GitHub: https://github.com/codership/galera/issues/596 3) I assume there is a problem in the wsrep provider when it determines the Galera full version I've updated the PRs please review them if you can. I've split the commits, great advice, thank you FEDORA-2021-85a90d9a97 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-85a90d9a97 FEDORA-2021-6a9b3cf880 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-6a9b3cf880 FEDORA-2021-85a90d9a97 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2021-6a9b3cf880 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-6a9b3cf880` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-6a9b3cf880 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-6a9b3cf880 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. |