Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 1959484 - FTBFS: galera 26.4.8; galera-25.3.33
Summary: FTBFS: galera 26.4.8; galera-25.3.33
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: galera
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Lukas Javorsky
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-05-11 15:55 UTC by Michal Schorm
Modified: 2021-06-19 01:13 UTC (History)
6 users (show)

Fixed In Version: galera-26.4.8-1.fc34 galera-26.4.8-1.fc33
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-11 01:15:28 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Michal Schorm 2021-05-11 15:55:18 UTC 
New releases of Galera FTBFS.

Error:
  "Provider version string '4.8(rXXXX)' not expected '26.4.8(rXXXX)'"
From file:
  galera-26.4.8/wsrep/tests/wsrep_loader_test.c                                                                                             

---

Galera 26 is used for mariadb in F35..F32 and mariadb modules 10.5 & 10.4 on F35..F32

Galera 25 is used for mariadb module 10.3 in F35..F32 (branch "mariadb-10.3")
Comment 1 Lukas Javorsky 2021-06-08 18:23:25 UTC 
PRs:
https://src.fedoraproject.org/rpms/galera/pull-request/6
https://src.fedoraproject.org/rpms/galera/pull-request/5

Scratch-builds:
25.3.33: https://koji.fedoraproject.org/koji/taskinfo?taskID=69609920
26.4.8: https://koji.fedoraproject.org/koji/taskinfo?taskID=69225761
Comment 2 Michal Schorm 2021-06-09 01:11:17 UTC 
The fix for the issue described in my initial comment seems OK.
Though, I don't see any comment, or better - explanation - why is the fix needed.

1)
 Is this issue reported upstream; or by chance, already fixed?
 If not, we should notify the upstream.

2)
 I would assume, the upstream runs the same tests. Why they haven't encountered an issue?

3)
 What did you find was the core of the issue?
 Based on the fix you propose, it seems like the Galera code is fine and the problem is in the test-suite.
 However without a description it is hard to check if it actually isn't the other way around by any chance.

4)
 I'd advise to split the commit into two commits.
 You are doing two separate things - first one is the rebase itself; second one is the fix of the test.

 Direct benefit is the clarity of the resulting code updates,
 secondary benefit may come e.g. when the fix won't be needed any longer, and we can just call "git revert" on it, and target only what we intend (without the rebase part)
Comment 3 Lukas Javorsky 2021-06-09 10:00:42 UTC 
1)
I found the issue reported on GitHub: https://github.com/codership/galera/issues/596

3)
I assume there is a problem in the wsrep provider when it determines the Galera full version

I've updated the PRs please review them if you can.
I've split the commits, great advice, thank you
Comment 4 Fedora Update System 2021-06-10 02:21:59 UTC 
FEDORA-2021-85a90d9a97 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-85a90d9a97
Comment 5 Fedora Update System 2021-06-10 02:22:00 UTC 
FEDORA-2021-6a9b3cf880 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-6a9b3cf880
Comment 6 Fedora Update System 2021-06-11 01:15:28 UTC 
FEDORA-2021-85a90d9a97 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 7 Fedora Update System 2021-06-11 01:42:25 UTC 
FEDORA-2021-6a9b3cf880 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-6a9b3cf880`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-6a9b3cf880

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 8 Fedora Update System 2021-06-19 01:13:55 UTC 
FEDORA-2021-6a9b3cf880 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.