Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 196403
| Summary: | Review Request: perl-Calendar-Simple - Perl extension to create simple calendars | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralf Corsepius <rc040203> |
| Component: | Package Review | Assignee: | Paul Howarth <paul> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-06-23 11:48:37 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779, 196430 | ||
|
Description
Ralf Corsepius
2006-06-22 23:59:07 UTC
Not an official review as I'm not yet sponsored
Mock build for i386 development is successfull.
MUST Items:
- MUST: rpmlint shows no error
- MUST: dist tag is present
- MUST: The package is named according to the Package Naming Guidelines.
- MUST: The spec file name matching the base package perl-Calender-Simple,
in the format perl-Calender-Simple.spec
- MUST: This package meets the Packaging Guidelines.
- MUST: The package is licensed with an open-source compatible license GPL.
- MUST: The License field in the package perl-Calender-Simple.spec file
matches the actual license file COPYING in tarball.
- MUST: The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct.
- MUST: This package owns all directories that it creates.
- MUST: This package did not contain any duplicate files in the %files
listing.
- MUST: This package have a %clean section, which contains rm -rf
$RPM_BUILD_ROOT.
- MUST: This package used macros.
- MUST: Document files are included like README.
* Source URL is Not present.
I need to remove DA from URL. Working Source URL for me
http://search.cpan.org/CPAN/authors/id/D/DAVECROSS/Calendar-Simple-1.13.tar.gz
* BuildRoot is correct BuildRoot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* BuildRequires is correct
Fixed Source0. Updated packages soon available at: ftp://ftp.uni-erlangen.de/pub/mirrors/packman/fedora/SRPMS/perl-Calendar-Simple.spec ftp://ftp.uni-erlangen.de/pub/mirrors/packman/fedora/SRPMS/perl-Calendar-Simple-1.13-2.src.rpm Review: - rpmlint clean - package and spec naming OK - package meets guidelines - license is same as perl, matches spec - spec file written in English and is legible - sources match upstream - package builds ok in mock (devel i386) - BR's OK - no locales, libraries, subpackages, or pkgconfigs to worry about - no relocatable - no dorectory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code not content - no large docs, docs don't affect runtime - not a GUI app, no desktop file needed - no scriptlets The only small cosmetic nit is that the rpm tag values seems to be misaligned (I tried tab stops of 4 and 8, and neither were pretty) Approved. Thanks for the review, indentation modified after cvs import. |