Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 197459
| Summary: | Review Request: perl-Object-InsideOut | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-07-05 20:10:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Chris Weyl
2006-07-02 05:24:13 UTC
Your URL points to Class-InsideOut, not Object-InsideOut. perl(attributes) and perl(overload) are part of base Perl. Generally I won't see a BR: for a module that is part of base Perl as a blocker, but these are pragmas. What's next, perl(strict) and perl(warnings)? Is there really a reason for you to include these? Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * source files match upstream: cde46297b346e329996b0cd40e9b81df Object-InsideOut-1.45.tar.gz * latest version is being packaged. X BuildRequires are proper. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane: perl(Object::InsideOut) = 1.45 perl(Object::InsideOut::Exception) = 1.45 perl(Object::InsideOut::Results) = 1.45 perl(Object::InsideOut::Util) = 1.45 perl-Object-InsideOut = 1.45-0.fc6 = perl >= 0:5.006 perl(:MODULE_COMPAT_5.8.8) perl(B) perl(Exception::Class) perl(Object::InsideOut) >= 1.45 perl(Object::InsideOut::Exception) >= 1.45 perl(Object::InsideOut::Util) >= 1.45 perl(Scalar::Util) >= 1.10 perl(strict) perl(warnings) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is present and all tests pass: All tests successful. Files=32, Tests=541, 2 wallclock secs ( 1.98 cusr + 0.54 csys = 2.52 CPU) * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. Pragma point well taken -- buildrequires removed. URL corrected. Spec URL: http://home.comcast.net/~ckweyl/perl-Object-InsideOut.spec SRPM URL: http://home.comcast.net/~ckweyl/perl-Object-InsideOut-1.45-0.1.fc5.src.rpm Looks fine now. APPROVED +Import to CVS +Add to owners.list +Bump release, build for devel +devel build succeeds +Request branching +Close bug Thanks for the review! |