Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at
Bug 197459 - Review Request: perl-Object-InsideOut
Summary: Review Request: perl-Object-InsideOut
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
Depends On:
TreeView+ depends on / blocked
Reported: 2006-07-02 05:24 UTC by Chris Weyl
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2006-07-05 20:10:35 UTC
Type: ---

Attachments (Terms of Use)

Description Chris Weyl 2006-07-02 05:24:13 UTC
Spec URL:

This module provides comprehensive support for implementing classes using the
inside-out object model.

This module implements inside-out objects as anonymous scalar references that
are blessed into a class with the scalar containing the ID for the object
(usually a sequence number). For Perl 5.8.3 and later, the scalar reference is
set as readonly to prevent accidental modifications to the ID. Object data
(i.e., fields) are stored within the class's package in either arrays indexed
by the object's ID, or hashes keyed to the object's ID.

Comment 1 Jason Tibbitts 2006-07-03 20:26:04 UTC
Your URL points to Class-InsideOut, not Object-InsideOut.

perl(attributes) and perl(overload) are part of base Perl.  Generally I won't
see a BR: for a module that is part of base Perl as a blocker, but these are
pragmas.  What's next, perl(strict) and perl(warnings)?  Is there really a
reason for you to include these?

* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* source files match upstream:
   cde46297b346e329996b0cd40e9b81df  Object-InsideOut-1.45.tar.gz
* latest version is being packaged.
X BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
   perl(Object::InsideOut) = 1.45
   perl(Object::InsideOut::Exception) = 1.45
   perl(Object::InsideOut::Results) = 1.45
   perl(Object::InsideOut::Util) = 1.45
   perl-Object-InsideOut = 1.45-0.fc6
   perl >= 0:5.006
   perl(Object::InsideOut) >= 1.45
   perl(Object::InsideOut::Exception) >= 1.45
   perl(Object::InsideOut::Util) >= 1.45
   perl(Scalar::Util) >= 1.10
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
   All tests successful.
   Files=32, Tests=541,  2 wallclock secs ( 1.98 cusr +  0.54 csys =  2.52 CPU)
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

Comment 2 Chris Weyl 2006-07-04 00:02:01 UTC
Pragma point well taken -- buildrequires removed.

URL corrected.

Spec URL:

Comment 3 Jason Tibbitts 2006-07-05 18:56:29 UTC
Looks fine now.


Comment 4 Chris Weyl 2006-07-05 20:10:35 UTC
+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching
+Close bug

Thanks for the review!

Note You need to log in before you can comment on or make changes to this bug.