Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 197461
Summary: | Review Request: perl-Class-InsideOut | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
Component: | Package Review | Assignee: | Jochen Schmitt <jochen> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-07-07 03:29:36 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Chris Weyl
2006-07-02 05:56:31 UTC
Good: + Tarball match with upstream. + rpmlint doesn't complaints source rpm. + Local build works fine. + Package contains verbatin copy of the license. + rpmlint doesn't complaint the binary rpm. Bad: - Perl have not to be inclussion in the BR. Is the inclusion of perl a blocker for approval? The review guidelines say: "- MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines; inclusion of those as BuildRequires is optional. Apply common sense." (In reply to comment #2) > Is the inclusion of perl a blocker for approval? s/of perl a/of perl in BR a/: no. On the other hand, FWIW, in this case there are various other perl(Foo::Bar) build dependencies which are unlikely to suddenly change so that the main perl package would not be pulled in. ihave read the Packaging Guidelines again. The packages in the exception list may be listed as a BR optional. So that this is not a blocker. I will APPROVED your package now. +Import to CVS +Add to owners.list +Bump release, build for devel +devel build succeeds +Request branching +Close bug Thanks for the review! |