Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 198025
| Summary: | Review Request: xorg-x11-drv-amd | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adam Jackson <ajax> |
| Component: | Package Review | Assignee: | David Cantrell <dcantrell> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, xgl-maint |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-07-12 14:46:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 188268, 191527 | ||
|
Description
Adam Jackson
2006-07-08 04:45:33 UTC
FEEDBACK:
- Since you went to the trouble of defining gitdate, might as well use it in
Source0 (:
- driver packages shouldn't own %{_libdir}/x11/modules or
%{_libdir}/x11/modules/drivers. These are owned by xorg-x11-server-Xorg, which
all drivers require.
Other than that, it looks good. Fix those, and I can approve it.
Updated URLs: http://people.freedesktop.org/~ajax/xorg-x11-drv-amd/xorg-x11-drv-amd.spec http://people.freedesktop.org/~ajax/xorg-x11-drv-amd/xorg-x11-drv-amd-0.0-1.git20060707.fc6.src.rpm Problems fixed, and the name changed per guidelines. Approving. imported, woo! |