Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 198025 - Review Request: xorg-x11-drv-amd
Summary: Review Request: xorg-x11-drv-amd
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Cantrell
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FC-ACCEPT 191527
TreeView+ depends on / blocked
 
Reported: 2006-07-08 04:45 UTC by Adam Jackson
Modified: 2013-01-10 01:26 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-07-12 14:46:42 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Adam Jackson 2006-07-08 04:45:33 UTC 
Spec URL:
http://people.freedesktop.org/~ajax/xorg-x11-drv-amd/xorg-x11-drv-amd.spec

SRPM URL:
http://people.freedesktop.org/~ajax/xorg-x11-drv-amd/xorg-x11-drv-amd-0.0-0.git20060707.fc6.src.rpm

Description:

Updated X driver from AMD for Geode GPUs, such as those on the OLPC board.  Taken from a git snapshot for now.

Spec file was based on that of the existing nsc driver.
Comment 1 Jesse Keating 2006-07-11 14:05:49 UTC 
FEEDBACK:
- Since you went to the trouble of defining gitdate, might as well use it in
Source0 (:
- driver packages shouldn't own %{_libdir}/x11/modules or
%{_libdir}/x11/modules/drivers.  These are owned by xorg-x11-server-Xorg, which
all drivers require.

Other than that, it looks good.  Fix those, and I can approve it.
Comment 2 Adam Jackson 2006-07-11 20:59:12 UTC 
Updated URLs:

http://people.freedesktop.org/~ajax/xorg-x11-drv-amd/xorg-x11-drv-amd.spec
http://people.freedesktop.org/~ajax/xorg-x11-drv-amd/xorg-x11-drv-amd-0.0-1.git20060707.fc6.src.rpm
Comment 3 Jesse Keating 2006-07-11 21:06:51 UTC 
Problems fixed, and the name changed per guidelines.

Approving.
Comment 4 Adam Jackson 2006-07-12 14:46:42 UTC 
imported, woo!
Note You need to log in before you can comment on or make changes to this bug.