Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 200151
Summary: | Review Request: perl-POE-Wheel-Null | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-07-27 15:04:49 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 200152 |
Description
Chris Weyl
2006-07-25 18:44:15 UTC
Well, this is pretty simple. The only comment I have is that the extra bit in the description is pretty obscure (I'm not a Star Trek fan and had to look it up, geek cred--) and doesn't seem to come from the description in the package's documentation. Review: * source files match upstream: 8abee8da7a141aca6c0bff6517ca8497 POE-Wheel-Null-0.01.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper (BR: perl is not necessary) * noarch package; no compiler flags are passed. * %clean is present. * package builds in mock (development, x86_64). * noarch package; no debuginfo. * rpmlint is silent. * final provides and requires are sane: perl(POE::Wheel::Null) = 0.01 perl-POE-Wheel-Null = 0.01-0.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(POE) perl(base) perl(strict) perl(vars) * %check is present and all tests (test?) pass: All tests successful. Files=1, Tests=1, 0 wallclock secs ( 0.01 cusr + 0.01 csys = 0.02 CPU) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. (Technically the documentation is twice the size of the code, but the whole package is only 5K.) * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED "D*mnit Jim, I'm a reviewing-machine, not a moon shuttle engineer!" :) +Import to CVS +Add to owners.list +Bump release, build for devel +devel build succeeds +Request branching (FC-5) +Close bug Thanks for the review! |