Note: This is a public test instance of Red Hat Bugzilla. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback at bugzilla.redhat.com.
Bug 200151 - Review Request: perl-POE-Wheel-Null
Summary: Review Request: perl-POE-Wheel-Null
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT 200152
TreeView+ depends on / blocked
 
Reported: 2006-07-25 18:44 UTC by Chris Weyl
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-07-27 15:04:49 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Chris Weyl 2006-07-25 18:44:15 UTC
Spec URL: http://home.comcast.net/~ckweyl/perl-POE-Wheel-Null.spec
SRPM URL: http://home.comcast.net/~ckweyl/perl-POE-Wheel-Null-0.01-0.fc5.src.rpm

Description: 
POE::Wheel::Null creates a wheel which doesn't do anything upon put(), and
doesn't send any events to the current session.

Its function is the same as those pipes in the Enterprise's engine room
marked "GNDN".

Comment 1 Jason Tibbitts 2006-07-26 23:55:43 UTC
Well, this is pretty simple.  The only comment I have is that the extra bit in
the description is pretty obscure (I'm not a Star Trek fan and had to look it
up, geek cred--) and doesn't seem to come from the description in the package's
documentation.

Review:
* source files match upstream:
   8abee8da7a141aca6c0bff6517ca8497  POE-Wheel-Null-0.01.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text not included upstream.
* latest version is being packaged.
* BuildRequires are proper (BR: perl is not necessary)
* noarch package; no compiler flags are passed.
* %clean is present.
* package builds in mock (development, x86_64).
* noarch package; no debuginfo.
* rpmlint is silent.
* final provides and requires are sane:
   perl(POE::Wheel::Null) = 0.01
   perl-POE-Wheel-Null = 0.01-0.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(POE)
   perl(base)
   perl(strict)
   perl(vars)
* %check is present and all tests (test?) pass:
   All tests successful.
   Files=1, Tests=1,  0 wallclock secs ( 0.01 cusr +  0.01 csys =  0.02 CPU)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
  (Technically the documentation is twice the size of the code, but the whole
package is only 5K.)
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED

Comment 2 Chris Weyl 2006-07-27 15:04:49 UTC
"D*mnit Jim, I'm a reviewing-machine, not a moon shuttle engineer!" :)

+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching (FC-5)
+Close bug

Thanks for the review!


Note You need to log in before you can comment on or make changes to this bug.